[API] Add an delete tag option to DELETE releases

[sigma-frossignol]

When the release is deleted via the web interface the tag is deleted
When the release is deleted via the API the tag is not deleted

The DeleteReleaseByID function already has an argument to either delete or not the tag.

that argument is set to true when called from the web interface

gitea/routers/repo/release.go

Line 353 in 3878e98

if err := releaseservice.DeleteReleaseByID(ctx.QueryInt64("id"), ctx.User, true); err != nil {

and to false when called from the API

gitea/routers/api/v1/repo/release.go

Line 333 in 3878e98

if err := releaseservice.DeleteReleaseByID(id, ctx.User, false); err != nil {

that'd be nice we could decide wether or not we want to delete the tag whith the API call

Thanks in advance

[6543]

related to #12913

[6543]

I think this can be done as in query option?
or should we start sending a json in body ... ?

github does not have this option so we are free to invent one

[jolheiser]

From what I can tell, there isn't really a defined standard. You can send query parameters and you can send a body with a DELETE request, however it is not in the spec (from what I could tell) and so it would be somewhat undefined territory.

I think, unfortunately, this should probably be delegated to #12913 and will require two API calls to completely remove a release and tag.
When this is implemented in the SDK, we could possibly add a convenience parameter so that it can remove the tag at the same time as the release.

On another note, the UI should also provide the option to retain the tag, for some of the reasons mentioned below relating to git.

---

I think this is fine when considering git has no concept of a release (it as a construct made up by services like ourselves and GH).

Releases are tied to tags, thus creating a release means creating the required tag as well.
However, deleting a release does not inherently mean the tag should be deleted, because tags can be created via git itself.

[jolheiser]

Resolved with #13358