Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub migration: Show "API rate limit of 5000 still exceeded" to user #13242

Closed
2 of 7 tasks
davidak opened this issue Oct 21, 2020 · 4 comments · Fixed by #13246
Closed
2 of 7 tasks

GitHub migration: Show "API rate limit of 5000 still exceeded" to user #13242

davidak opened this issue Oct 21, 2020 · 4 comments · Fixed by #13246
Labels
topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them

Comments

@davidak
Copy link

davidak commented Oct 21, 2020

  • Gitea version (or commit ref): 1.13.0+rc1
  • Git version: 2.20.1
  • Operating system: debian stable 10.6
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • i get migration failed too, but can't look into your logs ;)

Description

When i try to migrate a big GitHub repo, i see that the API limit is reached in the logs, but as an end-user, i see just "migration failed" without reason.

Please show it also to the user and what they can do.

API rate limit of 5000 still exceeded until 2020-10-21 16:33:28 +0200 CEST

Just wait and try again.

Related to #13241

Log

modules/task/task.go:51:handle() [E] Run task failed: GET https://api.github.com/repos/NixOS/nixpkgs: 403 API rate limit of 5000 still exceeded until 2020-10-21 16:33:28 +0200 CEST, not making remote request. [rate reset in 34m49s]

Screenshots

Screenshot from 2020-10-21 17-31-45

@zeripath
Copy link
Contributor

A repository notice is always created if there is a failure.

if err2 := models.CreateRepositoryNotice(fmt.Sprintf("Migrate repository from %s failed: %v", opts.OriginalURL, err)); err2 != nil {

That is of course slightly opaque.

@zeripath
Copy link
Contributor

Ah, but the error should be being set on the task...

t.Errors = err.Error()

@Codeberg-org
Copy link
Contributor

Just wait and try again.

For big repos retry will fail too -- something like sleep+resume migration might work?

zeripath added a commit to zeripath/gitea that referenced this issue Oct 21, 2020
When migrate tasks fail store the error in the task table
and ensure that they show on the status page.

Fix go-gitea#13242

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor

let's deal with one problem at a time

@6543 6543 added the topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them label Oct 23, 2020
techknowlogick added a commit that referenced this issue Oct 23, 2020
* Store task errors following migrations and display them

When migrate tasks fail store the error in the task table
and ensure that they show on the status page.

Fix #13242

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update web_src/js/index.js

* Hide the failed first

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick added a commit to techknowlogick/gitea that referenced this issue Oct 24, 2020
* Store task errors following migrations and display them

When migrate tasks fail store the error in the task table
and ensure that they show on the status page.

Fix go-gitea#13242

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update web_src/js/index.js

* Hide the failed first

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
lunny pushed a commit that referenced this issue Oct 24, 2020
)

* Store task errors following migrations and display them

When migrate tasks fail store the error in the task table
and ensure that they show on the status page.

Fix #13242

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update web_src/js/index.js

* Hide the failed first

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants