Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Link in Repo Description with tailing '_' do not work #13404

Closed
6543 opened this issue Nov 2, 2020 · 6 comments
Closed

[UI] Link in Repo Description with tailing '_' do not work #13404

6543 opened this issue Nov 2, 2020 · 6 comments
Assignees
@6543
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.12.6

Comments

@6543
Copy link
Member

6543 commented Nov 2, 2020

Gitea v1.12.5 (codeberg)

IF you put a link witch end with _ in the repo description the link you get to klick has no _ at the end.

demo: https://codeberg.org/jolson/relativitetsanteckningar
issue source: https://codeberg.org/Codeberg/Community/issues/330
@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 2, 2020
@techknowlogick
Copy link
Member

Are you able to replicate this on try.gitea.io?

@6543
Copy link
Member Author

6543 commented Nov 2, 2020 •
edited
Loading

@techknowlogick good catch!

EDIT: it's gone on 1.14.0+dev-134-g06268dcf5

@6543 6543 added this to the 1.12.6 milestone Nov 2, 2020
@mrsdizzie
Copy link
Member

Was fixed by xurls update here 12a1f91

mvdan/xurls@f319907

@zeripath
Copy link
Contributor

zeripath commented Nov 2, 2020

I don't think we can backport that to 1.12.6 - a backport to 1.13 for xurls alone is probably reasonable.

@6543
Copy link
Member Author

6543 commented Nov 3, 2020

I'll take this :) - and test if it's doable for 1.12.6 ...

@6543 6543 self-assigned this Nov 3, 2020
@6543 6543 mentioned this issue Nov 3, 2020
Merged
@6543
Copy link
Member Author

6543 commented Nov 3, 2020

@mrsdizzie thanks for the hint!!! - It would not be solved that quick otherwise 🎉

It realy was ...
-> #13407
-> #13408

@6543 6543 closed this as completed Nov 3, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@6543 6543

Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.12.6
Development

No branches or pull requests
4 participants
@techknowlogick @mrsdizzie @zeripath @6543