Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of showing diffs in the browser #1351

Closed
2 of 8 tasks
ghost opened this issue Mar 21, 2017 · 1 comment · Fixed by #16775
Closed
2 of 8 tasks

Improve performance of showing diffs in the browser #1351

ghost opened this issue Mar 21, 2017 · 1 comment · Fixed by #16775
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Milestone
1.16.0

Comments

@ghost
Copy link

ghost commented Mar 21, 2017

  • Gitea version (or commit ref): release/v1.1
  • Git version: 2.11.0
  • Operating system: GNU/Debian 9
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
    • Not relevant
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist: /
  • Browser: Firefox 52.0 (64-Bit)

Description

If you want to display some diffs while comparing, your browser may slow down. One should think about use somekind of async ajax loading.
@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 22, 2017
@lunny lunny added this to the 1.x.x milestone Mar 22, 2017
@bkcsoft bkcsoft changed the title browser slows down while displaying diffs Improve performance of showing diffs in the browser Apr 18, 2017
@stale
Copy link

stale bot commented Feb 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 15, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 28, 2019
@zeripath zeripath mentioned this issue Aug 26, 2021
Merged
zeripath added a commit that referenced this issue Aug 29, 2021
@zeripath
Simplify split diff view generation and remove JS dependency (#16775)
f5b0e2c 
Gitea has relied on some slow JS code to match up added and deleted lines on the
diff pages. This can cause a considerable slow down on large diff pages.

This PR makes a small change meaning that the matching up can occur much more simply.

Partial fix #1351

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Aug 29, 2021
@zeripath
Simplify split diff view generation and remove JS dependency (go-gite…
8d7c295 
…a#16775)

Backport go-gitea#16775

Gitea has relied on some slow JS code to match up added and deleted lines on the
diff pages. This can cause a considerable slow down on large diff pages.

This PR makes a small change meaning that the matching up can occur much more simply.

Partial fix go-gitea#1351

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Aug 29, 2021
Merged
zeripath added a commit that referenced this issue Aug 30, 2021
@zeripath
Simplify split diff view generation and remove JS dependency (#16775) (…
58f4a41 
…#16863)

Backport #16775

Gitea has relied on some slow JS code to match up added and deleted lines on the
diff pages. This can cause a considerable slow down on large diff pages.

This PR makes a small change meaning that the matching up can occur much more simply.

Partial fix #1351

Signed-off-by: Andrew Thornton <art27@cantab.net>
@lunny lunny modified the milestones: 1.x.x, 1.16.0 Sep 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Simplify split diff view generation and remove JS dependency zeripath/gitea
1 participant
@lunny