Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS requests causing HTTP basic auth popup #13759

Closed
silverwind opened this issue Nov 30, 2020 · 0 comments · Fixed by #13760
Closed

JS requests causing HTTP basic auth popup #13759

silverwind opened this issue Nov 30, 2020 · 0 comments · Fixed by #13760

Comments

@silverwind
Copy link
Member

silverwind commented Nov 30, 2020 •
edited
Loading

No exact steps to reproduce but I observe the following request while clicking/selecting code in the code view:

GET https://<server>/<user>/<repo>/commit/undefined?undefined&anchor=undefined

Backend will route this request to the git+https router which in turn will ask for basic auth. We should make sure to not send such bogus requests from JS.
@silverwind silverwind mentioned this issue Nov 30, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Nov 30, 2020
@silverwind
Fix bogus http requests on diffs
935c3c7 
The .blob-excerpt elements don't have these data attributes in some
cases resulting in bogus http request when expanding a diff and clicking
into the expanded area. This prevents those.

Should backport to 1.13.

Fixes: go-gitea#13759
techknowlogick pushed a commit that referenced this issue Nov 30, 2020
@silverwind
Fix bogus http requests on diffs (#13760)
21cf205 
The .blob-excerpt elements don't have these data attributes in some
cases resulting in bogus http request when expanding a diff and clicking
into the expanded area. This prevents those.

Should backport to 1.13.

Fixes: #13759
silverwind added a commit to silverwind/gitea that referenced this issue Nov 30, 2020
@silverwind
Fix bogus http requests on diffs (go-gitea#13760)
a4bc955 
The .blob-excerpt elements don't have these data attributes in some
cases resulting in bogus http request when expanding a diff and clicking
into the expanded area. This prevents those.

Should backport to 1.13.

Fixes: go-gitea#13759
techknowlogick pushed a commit that referenced this issue Nov 30, 2020
@silverwind
Fix bogus http requests on diffs (#13760) (#13761)
6e14773 
The .blob-excerpt elements don't have these data attributes in some
cases resulting in bogus http request when expanding a diff and clicking
into the expanded area. This prevents those.

Should backport to 1.13.

Fixes: #13759
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bogus http requests on diffs silverwind/gitea
1 participant
@silverwind