Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] SHA links in timeline (sub)events may look better in monospace #15049

Closed
1 of 6 tasks
CL-Jeremy opened this issue Mar 19, 2021 · 3 comments · Fixed by #15376
Closed
1 of 6 tasks

[UI] SHA links in timeline (sub)events may look better in monospace #15049

CL-Jeremy opened this issue Mar 19, 2021 · 3 comments · Fixed by #15376

Comments

@CL-Jeremy
Copy link
Contributor

Description

...

Somehow I stumbled on this while reworking on frontend. I compared the relevant snippets from /repo/issue/view_content/comments.tmpl and pull.tmpl and see no real difference whatsoever. Any thoughts?

Screenshots

-3 - --gitignore- を更新 - Test - Gitea- Git with a cup of tea 3-19-2021 5-37-29 PM
@CL-Jeremy
Copy link
Contributor Author

Bump this.

@CL-Jeremy CL-Jeremy changed the title Markup renderer sometimes fails to add surrounding <code></code> for SHA links [UI] Markup renderer sometimes fails to add surrounding <code></code> for SHA links Apr 7, 2021
@lunny
Copy link
Member

lunny commented Apr 8, 2021

Is this related with the translation string which hasn't contain a link tag?

@CL-Jeremy
Copy link
Contributor Author

Is this related with the translation string which hasn't contain a link tag?

D'oh, lol. didn't see it's hard-coded.

Then it's just up to the design (not a bug). Whichever the community prefers, the code is inherently correct.

@CL-Jeremy CL-Jeremy changed the title [UI] Markup renderer sometimes fails to add surrounding <code></code> for SHA links [UI] SHA links in timeline (sub)events may look better in monospace Apr 9, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Apr 9, 2021
@zeripath
SHA in merged commit comment should be rendered ui sha
d1c4a8e 
On a PR page the sha of the merge commit should be rendered in monospace
as a SHA. Also fixes an issue with the manually merged string.

Fix go-gitea#15049

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Apr 9, 2021
Merged
techknowlogick added a commit that referenced this issue Apr 10, 2021
@zeripath @techknowlogick
SHA in merged commit comment should be rendered ui sha (#15376)
9a0858c 
* SHA in merged commit comment should be rendered ui sha

On a PR page the sha of the merge commit should be rendered in monospace
as a SHA. Also fixes an issue with the manually merged string.

Fix #15049

Signed-off-by: Andrew Thornton <art27@cantab.net>

* issues.force_push_codes needs this too.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @techknowlogick @AbdulrhmnGhanem
SHA in merged commit comment should be rendered ui sha (go-gitea#15376)
8529f2a 
* SHA in merged commit comment should be rendered ui sha

On a PR page the sha of the merge commit should be rendered in monospace
as a SHA. Also fixes an issue with the manually merged string.

Fix go-gitea#15049

Signed-off-by: Andrew Thornton <art27@cantab.net>

* issues.force_push_codes needs this too.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SHA in merged commit comment should be rendered ui sha zeripath/gitea
2 participants
@lunny @CL-Jeremy