Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuelist icon too high #15386

Closed
1 of 2 tasks
zeripath opened this issue Apr 10, 2021 · 9 comments
Closed
1 of 2 tasks

Issuelist icon too high #15386

zeripath opened this issue Apr 10, 2021 · 9 comments
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@zeripath
Copy link
Contributor

Description

The issue list icon is now too high

Screenshots

Screenshot from 2021-04-10 12-36-02

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Apr 10, 2021
@zeripath
Copy link
Contributor Author

Could fix this by sticking an ac in the class here:

<div class="issue-item-left df py-1">

which would make this:

Screenshot from 2021-04-10 12-51-31

@silverwind
Copy link
Member

silverwind commented Apr 10, 2021

The icon should be centered on the first text line, so I guess it needs manual positioning.

silverwind added a commit to silverwind/gitea that referenced this issue Apr 10, 2021
@silverwind
Copy link
Member

silverwind commented Apr 14, 2021

I can not reproduce the original screenshot on latest Chrome. Can you try updating Chrome?

#15391 (comment)

@zeripath
Copy link
Contributor Author

it persists.

@zeripath
Copy link
Contributor Author

the issue may be related to segoe ui on linux

@silverwind
Copy link
Member

Yeah must be something like that. It's kind of hard to align this properly. I guess I'd need to boot up a Linux VM to verify.

@zeripath
Copy link
Contributor Author

I think it's just Segoe UI - its baseline sits 2.5px below the svg height.

https://core.trac.wordpress.org/ticket/48423

I'm not certain how we can handle it except by abandoning segoe-ui. I might just remove it from my fonts as I only occasionally need it.

@zeripath
Copy link
Contributor Author

Do we know if Windows has the same problem?

@zeripath
Copy link
Contributor Author

The NotoSans looks like the baseline is perhaps 1px below the svg.

@zeripath zeripath closed this as completed May 9, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants