Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown table alignment ignored #15959

Closed
5 tasks
oxydicer opened this issue May 23, 2021 · 1 comment · Fixed by #16596
Closed
5 tasks

Markdown table alignment ignored #15959

oxydicer opened this issue May 23, 2021 · 1 comment · Fixed by #16596
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented outdated/theme/markdown type/enhancement An improvement of existing functionality

Comments

@oxydicer
Copy link

  • Gitea version (or commit ref): 1.14.2

  • Git version: 2.25.1

  • Operating system: Ubuntu 20.04.2 LTS, using the official gitea binary, gitea-1.14.2-linux-amd64

  • Database (use [x]):

    • PostgreSQL
    • MySQL
    • MSSQL
    • [x ] SQLite
  • Can you reproduce the bug at https://try.gitea.io:

    • Yes (provide example URL)
    • No
  • Log gist:

Description

This bug has already been mentioned in #8577
In our gitea instance, when inserting a markdown like

| a11111    | b1111    | c1111    |
|-----------|:--------:|---------:|
| a1        |    b1    |       c2 |
| a3        |    b2    |       c3 |

The rendering of the markdown does not include the alignment information.
The html code that gets generated looks like

<table>
<thead>
<tr>
<th>a11111</th>
<th>b1111</th>
<th>c1111</th>
</tr>
</thead>
<tbody>
<tr>
<td>a1</td>
<td>b1</td>
<td>c2</td>
</tr>
<tr>
<td>a3</td>
<td>b2</td>
<td>c3</td>
</tr>
</tbody>
</table>

In our case the problem is not restricted to README.md, but to all .md files.

...

Screenshots

@noerw noerw added type/enhancement An improvement of existing functionality outdated/theme/markdown labels May 24, 2021
@stale
Copy link

stale bot commented Jul 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 24, 2021
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 24, 2021
@stale stale bot removed the issue/stale label Jul 24, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Aug 1, 2021
Set the TableOptions in markdown to allow alignment of the tables to work correctly

Fix go-gitea#15959

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this issue Aug 2, 2021
Set the TableOptions in markdown to allow alignment of the tables to work correctly

Fix #15959

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Aug 2, 2021
Backport go-gitea#16596

Set the TableOptions in markdown to allow alignment of the tables to work correctly

Fix go-gitea#15959

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this issue Aug 3, 2021
Backport #16596

Set the TableOptions in markdown to allow alignment of the tables to work correctly

Fix #15959

Signed-off-by: Andrew Thornton <art27@cantab.net>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
Set the TableOptions in markdown to allow alignment of the tables to work correctly

Fix go-gitea#15959

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented outdated/theme/markdown type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants