Skip to content

Mismatched instructions for SSH/HTTPs #16295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
adyanth opened this issue Jun 29, 2021 · 2 comments · Fixed by #16302
Closed
2 of 6 tasks

Mismatched instructions for SSH/HTTPs #16295

adyanth opened this issue Jun 29, 2021 · 2 comments · Fixed by #16302
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI
Milestone
1.15.0

Comments

@adyanth
Copy link
Contributor

adyanth commented Jun 29, 2021 •
edited
Loading

  • Gitea version (or commit ref): 1.15.0+dev-494-g35f37a362 built with GNU Make 4.3, go1.16.5 : bindata, timetzdata, sqlite, sqlite_unlock_notify
  • Git version: 2.30.2
  • Operating system: Ubuntu-20.04 Docker install
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

See below. The instructions don't match the protocol selected after creating a repo, and on every reload.

Screenshots

After creating a repo
image

2nd repo
image

Switch to SSH
image

Switch back to HTTPS
image

Reload page
image

This is inconsistent behavior as one would expect the instructions to align with the selected scheme.
@6543 6543 added this to the 1.15.0 milestone Jun 29, 2021
@6543 6543 added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI labels Jun 29, 2021
@6543
Copy link
Member

6543 commented Jun 29, 2021

note: if you klick to ssh and back to https, it get changed to a valid https commands ...

@adyanth
Copy link
Contributor Author

adyanth commented Jun 29, 2021

Yes, also provided screenshots for the same.
Meaning it can show https commands, but won't do by default.

zeripath added a commit to zeripath/gitea that referenced this issue Jun 29, 2021
@zeripath
Fix default push instructions on empty repos
a3f4c5e 
Use script block like in `repo/clone_buttons.tmpl` to set default instructions
for pushing to empty repos.

Fix go-gitea#16295

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jun 29, 2021
Merged
6543 pushed a commit that referenced this issue Jun 30, 2021
@zeripath
Fix default push instructions on empty repos (#16302)
71c7d0a 
* Fix default push instructions on empty repos

Use script block like in `repo/clone_buttons.tmpl` to set default instructions
for pushing to empty repos.

Fix #16295

Signed-off-by: Andrew Thornton <art27@cantab.net>
@delvh delvh mentioned this issue Aug 7, 2021
Closed
3 tasks
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Fix default push instructions on empty repos (go-gitea#16302)
bc51168 
* Fix default push instructions on empty repos

Use script block like in `repo/clone_buttons.tmpl` to set default instructions
for pushing to empty repos.

Fix go-gitea#16295

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

Fix default push instructions on empty repos zeripath/gitea
2 participants
@6543 @adyanth