Pull request with long commit message in title fails to open #16507
Comments
|
There will be an error being returned from the create pull request that is not being handled correctly. Are you able to provide server logs from when the pull request is attempted to be created? |
|
Here are the logs at debug level when I make the POST request to open a PR. Let me know if you need SQL logs or trace-level logs. |
|
hmm... not greatly useful... OK I've worked it out and pushed up a PR to fix this. |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jul 22, 2021
The CompareAndPullRequestPost handler for POST to /compare incorrectly handles returning errors to the user. For a start it does not set the necessary markers to switch SimpleMDE but it also does not immediately return to the form. This PR fixes this by setting the appropriate values, fixing the templates and preventing the suggestion of a too long title. Fix go-gitea#16507 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this issue
Jul 25, 2021
The CompareAndPullRequestPost handler for POST to /compare incorrectly handles returning errors to the user. For a start it does not set the necessary markers to switch SimpleMDE but it also does not immediately return to the form. This PR fixes this by setting the appropriate values, fixing the templates and preventing the suggestion of a too long title. Fix #16507 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jul 26, 2021
Backport go-gitea#16517 The CompareAndPullRequestPost handler for POST to /compare incorrectly handles returning errors to the user. For a start it does not set the necessary markers to switch SimpleMDE but it also does not immediately return to the form. This PR fixes this by setting the appropriate values, fixing the templates and preventing the suggestion of a too long title. Fix go-gitea#16507 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this issue
Jul 26, 2021
Backport #16517 The CompareAndPullRequestPost handler for POST to /compare incorrectly handles returning errors to the user. For a start it does not set the necessary markers to switch SimpleMDE but it also does not immediately return to the form. This PR fixes this by setting the appropriate values, fixing the templates and preventing the suggestion of a too long title. Fix #16507 Signed-off-by: Andrew Thornton <art27@cantab.net>
Thank you so much! |
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this issue
Aug 10, 2021
The CompareAndPullRequestPost handler for POST to /compare incorrectly handles returning errors to the user. For a start it does not set the necessary markers to switch SimpleMDE but it also does not immediately return to the form. This PR fixes this by setting the appropriate values, fixing the templates and preventing the suggestion of a too long title. Fix go-gitea#16507 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[x]):Browser logs enumerated below.
Description
If you create a pull request from a commit with a very long commit message (>255 characters) and try to open a pull request without trimming down the title, opening the pull request will fail without any error notification. Typically, if you try to create a commit message longer than 100 characters in the UI, it will tell you to shorten the message. Furthermore, if you try to create a pull request with too long of a title, the input box will prevent you from typing more characters. However, this can be circumvented. This issue can be reproduced by:
I was able to replicate this issue on try.gitea.io, but I also can replicate it on my private Gitea instance running 1.13.2 with PostgreSQL. This issue arose when a developer on my team said that they could not open a pull request. We sat down and troubleshooted the issue, narrowing it down to this problem.
The only fix this really needs is some kind of error message that notifies the user that they need to trim down their PR title.
Screenshots
2021-07-21_9-29-15.mp4
The text was updated successfully, but these errors were encountered: