Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a ticket shows it is closed by the opener not the doer #17942

Closed
eeyrjmr opened this issue Dec 10, 2021 · 3 comments · Fixed by #17973
Closed

Closing a ticket shows it is closed by the opener not the doer #17942

eeyrjmr opened this issue Dec 10, 2021 · 3 comments · Fixed by #17973
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug

Comments

@eeyrjmr
Copy link
Contributor

eeyrjmr commented Dec 10, 2021

Gitea Version

1.16.0+dev-670-gc7e23401a

Git Version

2.34

Operating System

Windows

How are you running Gitea?

Windows service

Database

MySQL

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

When an issue is closed, it correctly shows who closed the issue when you review the issue BUT the when you view the issue list it shows the issue has been closed by the person that opened the issue

https://try.gitea.io/eeyrjmr/test_issues/issues

Screenshots

Annotation 2021-12-10 000042

Annotation 2021-12-10 000117
@lunny lunny added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Dec 10, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 12, 2021 •
edited
Loading

I don't think that's a bug, it's just wrong wording. It should show the user which created the issue not the one who closed it.

Github uses the phrases
#xxx opened <time> by <creator>
#xxx by <creator> was closed <time>

Gitea uses
#xxx opened <time> by <creator>
#xxx closed <time> by <creator>
which misleads the user as closer.

@zeripath
Copy link
Contributor

This is a duplicate of another report. I guess it's time to just update the locale files and stop this once and for all.

@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 13, 2021

Just doing that right now.

zeripath added a commit to zeripath/gitea that referenced this issue Dec 13, 2021
@zeripath
Adjust issues.closed locale strings
221a66f 
Rearrange the order of by and closed to make it clearer that the user is the opening
user - not the closing user.

Fix go-gitea#17942

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Dec 13, 2021
Closed
@KN4CK3R KN4CK3R mentioned this issue Dec 13, 2021
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug
Projects
None yet
Milestone
No milestone
4 participants
@lunny @KN4CK3R @zeripath @eeyrjmr