Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files change number is not correct #18303

Closed
lunny opened this issue Jan 17, 2022 · 0 comments · Fixed by #18313
Closed

Files change number is not correct #18303

lunny opened this issue Jan 17, 2022 · 0 comments · Fixed by #18313
Labels
topic/pr Issues related to pull requests type/bug
Milestone
1.16.0

Comments

@lunny
Copy link
Member

lunny commented Jan 17, 2022

ref: https://gitea.com/xorm/xorm/pulls/1421/files
@lunny lunny added the type/bug label Jan 17, 2022
@noerw noerw added the topic/pr Issues related to pull requests label Jan 17, 2022
zeripath added a commit to zeripath/gitea that referenced this issue Jan 17, 2022
@zeripath
Use indirect comparison when showing pull requests
4c43b73 
When generating the commits list and number of files changed for PRs and
compare we should use "..." always not "..".

Fix go-gitea#18303

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jan 17, 2022
Merged
@zeripath zeripath added this to the 1.16.0 milestone Jan 17, 2022
zeripath added a commit that referenced this issue Jan 18, 2022
@zeripath
Use indirect comparison when showing pull requests (#18313)
089b4e6 
When generating the commits list and number of files changed for PRs and
compare we should use "..." always not "..".

Fix #18303

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@zeripath
Use indirect comparison when showing pull requests (go-gitea#18313)
a06aa36 
When generating the commits list and number of files changed for PRs and
compare we should use "..." always not "..".

Fix go-gitea#18303

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/pr Issues related to pull requests type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Use indirect comparison when showing pull requests zeripath/gitea
3 participants
@lunny @zeripath @noerw