Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Commits since last release' label broken #18307

Closed
OCram85 opened this issue Jan 17, 2022 · 4 comments
Closed

'Commits since last release' label broken #18307

OCram85 opened this issue Jan 17, 2022 · 4 comments
Labels

Comments

@OCram85
Copy link
Contributor

OCram85 commented Jan 17, 2022

Gitea Version

1.5.10

Git Version

2.30.2

Operating System

SLES 15 SP2

How are you running Gitea?

[2x haproxy / keepalived nodes] --- (ponting to traefik reverse proxy) ---> [ multiple docker swarm manager] ---- running ---> [ Single gitea container ]

Database

MySQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

The link label on the repo/release page seems to be broken The counter 0 commits

Can't reproduce it 100% on https://gitea.com/xorm/xorm/releases because #18226 isn't fixed on this instance.

The commits were always done via the same gitea workflow -> [Gitea PR] -> [Review] -> [Squash Commit / Merge to master].

Screenshots

image

image

@zeripath
Copy link
Contributor

OK I think this is working on 1.16.0

Screenshot from 2022-01-17 19-49-46

But what's really interesting is that if you look at your first picture the 1.0.3 release looks correct - except the DefaultBranch is incorrect.

@exu-g
Copy link

exu-g commented Sep 13, 2022

Broken again in 1.17.2. I've made 1 commit since this release.
grafik

Clicking the link does lead to the correct diff with 1 commit.
grafik

@lunny lunny added this to the 1.17.3 milestone Sep 19, 2022
@6543 6543 modified the milestones: 1.17.3, 1.17.4 Oct 13, 2022
@lunny lunny modified the milestones: 1.17.4, 1.17.5 Dec 21, 2022
@wxiaoguang
Copy link
Contributor

Come across this one.

Incorrect milestone, and .... whether it has been fixed?

@lunny lunny removed this from the 1.17.5 milestone Mar 20, 2023
@wxiaoguang
Copy link
Contributor

It should have been fixed by: fix calReleaseNumCommitsBehind (#24148)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants