Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When merging a PR and deleting the branch the info box text is not correct. #18785

Closed
noetzold opened this issue Feb 16, 2022 · 4 comments · Fixed by #22673
Closed

When merging a PR and deleting the branch the info box text is not correct. #18785

noetzold opened this issue Feb 16, 2022 · 4 comments · Fixed by #22673
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@noetzold
Copy link

noetzold commented Feb 16, 2022

Gitea Version

1.17.0+dev-172-g616146f90

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Kind of a cometic Issue
The text in the green info box is not correct when deleting a branch while merge a PR. See the Screenshot.

Only the organization is mentioned but not the repository:
"Branch 'Monty/test2' has been deleted."
It should be:
"Branch 'Monty/testing-Notifications test2' has been deleted."

Reproduce:
-Create a PR
-Create a merge commit and check "Delete Branch"
-See the green Box

Screenshots

image

@fnetX
Copy link
Contributor

fnetX commented Feb 16, 2022

I think it's supposed to refer to which repo the branch was from, like you would do locally with multiple remotes. It's obvious the branch belongs to this kind of repo, but it might have been from a fork (and then say "user-with-fork/branch" has been deleted)

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 17, 2022
@noetzold
Copy link
Author

OK, might be a matter of taste. It is just that Gitea identifiers a repro usually as organization/repro. I just came across this because I had a repro with the same name as the branch and thought for a second the branch has been deleted.

When the message is as indented, please close this Issue

@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 19, 2022
@lunny lunny added type/bug issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Apr 19, 2022
@stale stale bot removed issue/stale labels Apr 19, 2022
@JVimes
Copy link

JVimes commented Jan 30, 2023

Glad this was confirmed as a bug. Thanks.

@lunny lunny added this to the 1.19.0 milestone Jan 31, 2023
@lunny lunny added the outdated/backport/v1.18 This PR should be backported to Gitea 1.18 label Jan 31, 2023
lunny added a commit to lunny/gitea that referenced this issue Jan 31, 2023
@lunny lunny removed the outdated/backport/v1.18 This PR should be backported to Gitea 1.18 label Jan 31, 2023
@lunny lunny modified the milestones: 1.19.0, 1.18.4 Jan 31, 2023
zeripath pushed a commit that referenced this issue Feb 1, 2023
…UI (#22673) (#22698)

Backport #22673

Fix #18785

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants