cli `--must-change-password` not working

[loynoir]

Gitea Version

[Docker] Gitea version 1.16.3 built with GNU Make 4.3, go1.17.6 : bindata, timetzdata, sqlite, sqlite_unlock_notif

Git Version

No response

Operating System

No response

How are you running Gitea?

cli --must-change-password not working

$ docker run -p 3000:3000 -it gitea/gitea
$ docker exec -it $(docker ps|grep gitea|awk '{print $1}') bash

Visit Initial Configuration at http://localhost:3000/

# su git
$ gitea admin user create  --username foo  --password foo  --email foo@localhost  --must-change-password false

Still need to change password when first login

But using library generated by https://github.com/OpenAPITools/openapi-generator, --must-change-password false works fine.

Database

No response

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

No response

Screenshots

No response

[zeripath]

gitea admin user create --username foo --password foo --email foo@localhost --must-change-password=false

[zeripath]

Note the =

[noerw]

Looks like only bool flags require a = separator, afaik this is fixed in urfave/cli/v2.
But that version has quite stupid issues with flag / argument order when using global flags, that might be a blocker for switching to v2.

[loynoir]

gitea admin user create --username foo --password foo --email foo@localhost --must-change-password=false

Yes, confirmed working with = way

[zeripath]

I think the BoolTFlag may have a slightly nicer behaviour.

[techknowlogick]

@noerw you'll find v1 has same global ordering pattern, which we've worked around.

Gonna close this now though.

[decentral1se]

@noerw you'll find v1 has same global ordering pattern, which we've worked around.

@techknowlogick oh! would you mind sharing that work-around? i'm struggling with cli ordering with urfave also...

[zeripath]

gitea/main.go

Lines 109 to 127 in fda5b9f

	// Add functions to set these paths and these flags to the commands
	app.Before = establishCustomPath
	for i := range app.Commands {
	setFlagsAndBeforeOnSubcommands(&app.Commands[i], defaultFlags, establishCustomPath)
	}
	err := app.Run(os.Args)
	if err != nil {
	log.Fatal("Failed to run app with %s: %v", os.Args, err)
	}
	}
	func setFlagsAndBeforeOnSubcommands(command *cli.Command, defaultFlags []cli.Flag, before cli.BeforeFunc) {
	command.Flags = append(command.Flags, defaultFlags...)
	command.Before = establishCustomPath
	for i := range command.Subcommands {
	setFlagsAndBeforeOnSubcommands(&command.Subcommands[i], defaultFlags, before)
	}
	}

Look at the setFlagsAndBeforeOnSubcommands