CI random failure: TestExportUserGPGKeys #19961

wxiaoguang · 2022-06-13T12:41:36Z

https://drone.gitea.io/go-gitea/gitea/56043/3/8

--- FAIL: TestExportUserGPGKeys (0.65s)
    user_test.go:222: Testing username user1 export gpg keys
    testlogger.go:78: 2022/06/13 11:01:27 ...eb/routing/logger.go:99:func1() [I] [62a71907-28] router: completed GET /user1.gpg for , 200 OK in 11.2ms @ user/home.go:768(user.ShowGPGKeys)
    testlogger.go:78: 2022/06/13 11:01:27 ...eb/routing/logger.go:99:func1() [I] [62a71907-29] router: completed GET /user/settings/applications for , 200 OK in 27.9ms @ setting/applications.go:25(setting.Applications)
    testlogger.go:78: 2022/06/13 11:01:27 ...eb/routing/logger.go:99:func1() [I] [62a71907-30] router: completed POST /user/settings/applications for , 303 See Other in 17.0ms @ context/auth.go:27(context.Toggle)
    testlogger.go:78: 2022/06/13 11:01:28 ...eb/routing/logger.go:99:func1() [I] [62a71907-31] router: completed GET /user/settings/applications for , 200 OK in 32.1ms @ setting/applications.go:25(setting.Applications)
    testlogger.go:78: 2022/06/13 11:01:28 ...eb/routing/logger.go:99:func1() [I] [62a71908] router: completed POST /api/v1/user/gpg_keys?token= for , 401 Unauthorized in 0.2ms @ v1/api.go:210(v1.reqToken)
    api_gpg_keys_test.go:159: 
        	Error Trace:	integration_test.go:503
        	            				integration_test.go:332
        	            				api_gpg_keys_test.go:159
        	            				user_test.go:155
        	Error:      	Not equal: 
        	            	expected: 201
        	            	actual  : 401
        	Test:       	TestExportUserGPGKeys
        	Messages:   	Request: POST /api/v1/user/gpg_keys?token=
    api_gpg_keys_test.go:159: Response: {"message":"token is required","url":"http://localhost:3002/api/swagger"}
        
    user_test.go:222: Testing username user1 export gpg keys
    testlogger.go:78: 2022/06/13 11:01:28 ...eb/routing/logger.go:99:func1() [I] [62a71908-2] router: completed GET /user1.gpg for , 200 OK in 9.7ms @ user/home.go:768(user.ShowGPGKeys)
    user_test.go:226: 
        	Error Trace:	user_test.go:226
        	            				user_test.go:187
        	Error:      	Not equal: 
        	            	expected: "-----BEGIN PGP PUBLIC KEY BLOCK-----\n\nxsBNBFyy/VUBCADJ7zbM20Z1RWmFoVgp5WkQfI2rU1Vj9cQHes9i42wVLLtcbPeo\nQzubgzvMPITDy7nfWxgSf83E23DoHQ1ACFbQh/6eFSRrjsusp3YQ/08NSfPPbcu8\n0M5G+VGwSfzS5uEcwBVQmHyKdcOZIERTNMtYZx1C3bjLD1XVJHvWz9D72Uq4qeO3\n8SR+lzp5n6ppUakcmRnxt3nGRBj1+hEGkdgzyPo93iy+WioegY2lwCA9xMEo5dah\nBmYxWx51zyiXYlReTaxlyb3/nuSUt8IcW3Q8zjdtJj4Nu8U1SpV8EdaA1I9IPbHW\n510OSLmD3XhqHH5m6mIxL1YoWxk3V7gpDROtABEBAAHNGVVzZXIxIDx1c2VyMUBl\neGFtcGxlLmNvbT7CwI4EEwEIADgWIQTQEbrYxmXsp1z3j7z9+v0I6RSEHwUCXLL9\nVQIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD9+v0I6RSEH22YCACFqL5+\n6M0m18AMC/pumcpnnmvAS1GrrKTF8nOROA1augZwp1WCNuKw2R6uOJIHANrYECSn\nu7+j6GBP2gbIW8mSAzS6HWCs7GGiPpVtT4wcu8wljUI6BxjpyZtoEkriyBjt6HfK\nrkegbkuySoJvjq4IcO5D1LB1JWgsUjMYQJj/ZpBIzVtjG9QtFSOiT1Hct4PoZHdC\nnsdSgyCkwRZXG+u3kT/wP9F663ba4o16vYlz3dCGo66lF2tyoG3qcyZ1OUzUrnuv\n96ytAzT6XIhrE0nVoBprMxFF5zExotJD3bHjcGBFNLf944bhjKee3U6t9+OsfJVC\nl7N5xxIawCuTQdbfzsBNBFyy/VUBCADe61yGEoTwKfsOKIhxLaNoRmD883O0tiWt\nsoO/HPj9dPQLTOiwXgSgSCd8C+LNxGKct87wgFozpah4tDLC6c0nALuHJ0SLbkfz\n55aRhLeOOcrAydatDp72GroXzqpZ0xZBk5wjIWdgEol2GmVRM8QGbeuakU/HVz5y\nlPzxUUocgdbSi3GE3zbzijQzVJdyL/kw/KP7pKT/PPKKJ2C5NQDLy0XGKEHddXGR\nEWKkVlRalxq/TjfaMR0bi3MpezBsQmp99ATPO/d7trayZUxQHRtXzGFiOXfDHATr\nqN730sODjqvU+mpc/SHCRwh9qWDjZRHSuKU5YDBjb5jIQJivZsQ/ABEBAAHCwHYE\nGAEIACAWIQTQEbrYxmXsp1z3j7z9+v0I6RSEHwUCXLL9VQIbDAAKCRD9+v0I6RSE\nH7WoB/4tXl+97rQ6owPCGSVp1Xbwt2521V7COgsOFRVTRTryEWxRW8mm0S7wQvax\nC0TLXKur6NVYQMn01iyL+FZzRpEWNuYF3f9QeeLJ/+l2DafESNhNTy17+RPmacK6\n21dccpqchByVw/UMDeHSyjQLiG2lxzt8Gfx2gHmSbrq3aWovTGyz6JTffZvfy/n2\n0Hm437OBPazO0gZyXhdV2PE5RSUfvAgm44235tcV5EV0d32TJDfv61+Vr2GUbah6\n7XhJ1v6JYuh8kaYaEz8OpZDeh7f6Ho6PzJrsy/TKTKhGgZNINj1iaPFyOkQgKR5M\nGrE0MHOxUbc9tbtyk0F1SuzREUBH\n=WFf5\n-----END PGP PUBLIC KEY BLOCK-----\n"
        	            	actual  : "-----BEGIN PGP PUBLIC KEY BLOCK-----\nNote: This user hasn't uploaded any GPG keys.\n\n\n=twTO\n-----END PGP PUBLIC KEY BLOCK-----\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,30 +1,6 @@
        	            	 -----BEGIN PGP PUBLIC KEY BLOCK-----
        	            	+Note: This user hasn't uploaded any GPG keys.
        	            	 
        	            	-xsBNBFyy/VUBCADJ7zbM20Z1RWmFoVgp5WkQfI2rU1Vj9cQHes9i42wVLLtcbPeo
        	            	-QzubgzvMPITDy7nfWxgSf83E23DoHQ1ACFbQh/6eFSRrjsusp3YQ/08NSfPPbcu8
        	            	-0M5G+VGwSfzS5uEcwBVQmHyKdcOZIERTNMtYZx1C3bjLD1XVJHvWz9D72Uq4qeO3
        	            	-8SR+lzp5n6ppUakcmRnxt3nGRBj1+hEGkdgzyPo93iy+WioegY2lwCA9xMEo5dah
        	            	-BmYxWx51zyiXYlReTaxlyb3/nuSUt8IcW3Q8zjdtJj4Nu8U1SpV8EdaA1I9IPbHW
        	            	-510OSLmD3XhqHH5m6mIxL1YoWxk3V7gpDROtABEBAAHNGVVzZXIxIDx1c2VyMUBl
        	            	-eGFtcGxlLmNvbT7CwI4EEwEIADgWIQTQEbrYxmXsp1z3j7z9+v0I6RSEHwUCXLL9
        	            	-VQIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD9+v0I6RSEH22YCACFqL5+
        	            	-6M0m18AMC/pumcpnnmvAS1GrrKTF8nOROA1augZwp1WCNuKw2R6uOJIHANrYECSn
        	            	-u7+j6GBP2gbIW8mSAzS6HWCs7GGiPpVtT4wcu8wljUI6BxjpyZtoEkriyBjt6HfK
        	            	-rkegbkuySoJvjq4IcO5D1LB1JWgsUjMYQJj/ZpBIzVtjG9QtFSOiT1Hct4PoZHdC
        	            	-nsdSgyCkwRZXG+u3kT/wP9F663ba4o16vYlz3dCGo66lF2tyoG3qcyZ1OUzUrnuv
        	            	-96ytAzT6XIhrE0nVoBprMxFF5zExotJD3bHjcGBFNLf944bhjKee3U6t9+OsfJVC
        	            	-l7N5xxIawCuTQdbfzsBNBFyy/VUBCADe61yGEoTwKfsOKIhxLaNoRmD883O0tiWt
        	            	-soO/HPj9dPQLTOiwXgSgSCd8C+LNxGKct87wgFozpah4tDLC6c0nALuHJ0SLbkfz
        	            	-55aRhLeOOcrAydatDp72GroXzqpZ0xZBk5wjIWdgEol2GmVRM8QGbeuakU/HVz5y
        	            	-lPzxUUocgdbSi3GE3zbzijQzVJdyL/kw/KP7pKT/PPKKJ2C5NQDLy0XGKEHddXGR
        	            	-EWKkVlRalxq/TjfaMR0bi3MpezBsQmp99ATPO/d7trayZUxQHRtXzGFiOXfDHATr
        	            	-qN730sODjqvU+mpc/SHCRwh9qWDjZRHSuKU5YDBjb5jIQJivZsQ/ABEBAAHCwHYE
        	            	-GAEIACAWIQTQEbrYxmXsp1z3j7z9+v0I6RSEHwUCXLL9VQIbDAAKCRD9+v0I6RSE
        	            	-H7WoB/4tXl+97rQ6owPCGSVp1Xbwt2521V7COgsOFRVTRTryEWxRW8mm0S7wQvax
        	            	-C0TLXKur6NVYQMn01iyL+FZzRpEWNuYF3f9QeeLJ/+l2DafESNhNTy17+RPmacK6
        	            	-21dccpqchByVw/UMDeHSyjQLiG2lxzt8Gfx2gHmSbrq3aWovTGyz6JTffZvfy/n2
        	            	-0Hm437OBPazO0gZyXhdV2PE5RSUfvAgm44235tcV5EV0d32TJDfv61+Vr2GUbah6
        	            	-7XhJ1v6JYuh8kaYaEz8OpZDeh7f6Ho6PzJrsy/TKTKhGgZNINj1iaPFyOkQgKR5M
        	            	-GrE0MHOxUbc9tbtyk0F1SuzREUBH
        	            	-=WFf5
        	            	+
        	            	+=twTO
        	            	 -----END PGP PUBLIC KEY BLOCK-----
        	Test:       	TestExportUserGPGKeys
=== TestListStopWatches (integrations/user_test.go:230)
=== TestVersion (integrations/version_test.go:18)
=== TestRenderFileSVGIsInImgTag (integrations/view_test.go:15)
=== TestWebfinger (integrations/webfinger_test.go:21)
=== TestXSSUserFullName (integrations/xss_test.go:18)
FAIL

The text was updated successfully, but these errors were encountered:

silverwind · 2022-10-14T07:59:30Z

Please reopen, it's still happening a lot:

https://drone.gitea.io/go-gitea/gitea/61581/2/14
https://drone.gitea.io/go-gitea/gitea/61595/2/14

I would consider disabling the test.

zeripath · 2022-10-19T20:29:02Z

The problem is coming from:

gitea/tests/integration/user_test.go

Lines 153 to 156 in 1713beb

    
           // User1 <user1@example.com> 
        
           session := loginUser(t, "user1") 
        
           token := getTokenForLoggedInUser(t, session) 
        
           testCreateGPGKey(t, session.MakeRequest, token, http.StatusCreated, `-----BEGIN PGP PUBLIC KEY BLOCK-----

Now this sends the a POST request:

gitea/tests/integration/api_gpg_keys_test.go

Lines 156 to 157 in 1713beb

    
           func testCreateGPGKey(t *testing.T, makeRequest makeRequestFunc, token string, expected int, publicKey string) { 
        
           	req := NewRequestWithJSON(t, "POST", "/api/v1/user/gpg_keys?token="+token, api.CreateGPGKeyOption{

This POST request will send the session from line 154 above AND the token.

This is likely to be the cause of the problem.

silverwind · 2022-10-21T14:30:23Z

Should be fixed with #21520.

silverwind · 2022-10-25T09:33:11Z

Still happening: https://drone.gitea.io/go-gitea/gitea/62401/2/16

garymoon · 2022-11-15T17:32:23Z

Can confirm this continues to happen on 1.17 with the fix applied. It's not obvious to me how this could be a factor, but it only cropped up for us when we started running multiple copies of the pipeline concurrently.

Thanks for working on this everyone 💙

wxiaoguang · 2022-12-13T04:28:39Z

Replaced by

CI random failure: TestExportUserGPGKeys #22105

lunny · 2022-12-13T11:40:38Z

Sorry to forget this issue. :(

wxiaoguang · 2022-12-13T11:59:00Z

Never mind, I think the new issue is more helpful. This log in this issue has been out-dated (line number changes a lot indeed)

wxiaoguang added the type/testing label Jun 13, 2022

wxiaoguang closed this as completed Jul 26, 2022

wxiaoguang reopened this Oct 14, 2022

silverwind mentioned this issue Oct 19, 2022

Skip TestExportUserGPGKeys #21514

Closed

silverwind mentioned this issue Oct 20, 2022

Check for valid user token in integration tests #21520

Merged

silverwind closed this as completed Oct 21, 2022

silverwind reopened this Oct 25, 2022

wxiaoguang closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022

wxiaoguang added the issue/duplicate The issue has already been reported. label Dec 13, 2022

go-gitea locked and limited conversation to collaborators May 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI random failure: TestExportUserGPGKeys #19961

CI random failure: TestExportUserGPGKeys #19961

wxiaoguang commented Jun 13, 2022

silverwind commented Oct 14, 2022 •

edited

Loading

zeripath commented Oct 19, 2022

silverwind commented Oct 21, 2022

silverwind commented Oct 25, 2022

garymoon commented Nov 15, 2022

wxiaoguang commented Dec 13, 2022

lunny commented Dec 13, 2022

wxiaoguang commented Dec 13, 2022

CI random failure: TestExportUserGPGKeys #19961

CI random failure: TestExportUserGPGKeys #19961

Comments

wxiaoguang commented Jun 13, 2022

silverwind commented Oct 14, 2022 • edited Loading

zeripath commented Oct 19, 2022

silverwind commented Oct 21, 2022

silverwind commented Oct 25, 2022

garymoon commented Nov 15, 2022

wxiaoguang commented Dec 13, 2022

lunny commented Dec 13, 2022

wxiaoguang commented Dec 13, 2022

silverwind commented Oct 14, 2022 •

edited

Loading