Skip TestExportUserGPGKeys #21514
Closed
Skip TestExportUserGPGKeys #21514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
type/testing
skip-changelog
|
Hmm, I would prefer to find the root problem and fix the test instead of skipping it -- unless there is a strong reason that the test couldn't be fixed and must be skipped ..... |
GiteaBot
added
the
lgtm/need 2
|
As I see it, a randomly failing test just wastes everyone's time. It's worse than not being there in first place. |
|
We should find a way to mark individual tests as flaky so that they will execute but not trigger a step failure. |
|
Closing in favor of #21520. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is causing a lot of failures on CI and I'm not really motived to look into, so just skip it to make CI results more accurate.
Related: #19961