Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending Tooltip Doesn't Show For New Code Comments #20068

Closed
kdumontnu opened this issue Jun 21, 2022 · 3 comments · Fixed by #20234
Closed

Pending Tooltip Doesn't Show For New Code Comments #20068

kdumontnu opened this issue Jun 21, 2022 · 3 comments · Fixed by #20234
Labels
topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug
Milestone
1.17.0

Comments

@kdumontnu
Copy link
Contributor

kdumontnu commented Jun 21, 2022 •
edited
Loading

Description

The "Pending" tooltip for PR review comments doesn't show on new comments until the page is reloaded.

To recreate:

  • Go to an open PR.
  • Add comment on line of code
  • "Add to Review" (or "Start Review")
  • Hover cursor on "Pending"
  • Refresh page
  • Hover again

Gitea Version

1.18.0+dev-14-g1e2c2edab

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

See demo:
Pending-Tooltip

Git Version

No response

Operating System

No response

How are you running Gitea?

https://gitea.com/Kyle/Tester/pulls/1/files

Database

No response
@6543
Copy link
Member

6543 commented Jun 21, 2022

introduced at #19662 ...

@6543 6543 added this to the 1.17.0 milestone Jun 21, 2022
@6543 6543 added topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels Jun 21, 2022
@silverwind
Copy link
Member

silverwind commented Jun 21, 2022 •
edited
Loading

Fomantic tooltips need to be initialized after DOM content is modified. Solution should be to extract that initialization into a function and call it after DOM has been modified.

@wxiaoguang
Copy link
Contributor

Maybe it's time to drop the Fomantic popup, and use a global mouseenter event handler to popup the attached data-content.

@kdumontnu kdumontnu changed the title Pending Tooltip Doesn't Show Chrome Pending Tooltip Doesn't Show For New Code Comments Jun 21, 2022
Gusted pushed a commit to Gusted/gitea that referenced this issue Jul 5, 2022
Init popup for new code comment
33d5528 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17
- Resolves go-gitea#20068
@Gusted Gusted mentioned this issue Jul 5, 2022
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Jul 5, 2022
Init popup for new code comment (go-gitea#20234)
18eb5fe 
- Backport go-gitea#20234
  - Initialize the popup for the tooltip inside the new code comment.
  - This works and is good enough to have this issue fixed for 1.17
  - Resolves go-gitea#20068
@Gusted Gusted mentioned this issue Jul 5, 2022
Merged
zeripath pushed a commit that referenced this issue Jul 5, 2022
Init popup for new code comment (#20234)
ed13d7a 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17


Fix #20068
zeripath pushed a commit that referenced this issue Jul 5, 2022
Init popup for new code comment (#20234) (#20235)
f42fc3b 
- Backport #20234
 
  - Initialize the popup for the tooltip inside the new code comment.
  - This works and is good enough to have this issue fixed for 1.17
 
Fix #20068
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this issue Jul 9, 2022
@dineshsalunke
Init popup for new code comment (go-gitea#20234)
2b86075 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17


Fix go-gitea#20068
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
Init popup for new code comment (go-gitea#20234)
2b3a1a8 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17


Fix go-gitea#20068
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

Init popup for new code comment Gusted/gitea
4 participants
@silverwind @wxiaoguang @kdumontnu @6543