Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard feed no longer respects FEED_PAGING_NUM setting #20080

Closed
jpraet opened this issue Jun 22, 2022 · 1 comment · Fixed by #20094
Closed

Dashboard feed no longer respects FEED_PAGING_NUM setting #20080

jpraet opened this issue Jun 22, 2022 · 1 comment · Fixed by #20094
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Milestone
1.17.0

Comments

@jpraet
Copy link
Member

jpraet commented Jun 22, 2022 •
edited
Loading

Description

The feed in the dashboard view no longer respects the [ui] FEED_PAGING_NUM setting.
Instead, it looks like the [api] DEFAULT_PAGING_NUM setting is now used.

Reproducable on https://try.gitea.io/ where it shows 30 items instead of 20.

Gitea Version

1.17.0-rc1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

No response
@jpraet jpraet added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Jun 22, 2022
@jpraet jpraet added this to the 1.17.0 milestone Jun 22, 2022
@lunny
Copy link
Member

lunny commented Jun 22, 2022

Are you sure it was setting.UI.FeedPagingNum and the default value is 20?

@lunny lunny mentioned this issue Jun 22, 2022
Closed
jpraet added a commit to jpraet/gitea that referenced this issue Jun 22, 2022
@jpraet
Respect setting.UI.FeedPagingNum
e6831b1 
Fixes go-gitea#20080
@jpraet jpraet mentioned this issue Jun 22, 2022
Merged
lunny added a commit to jpraet/gitea that referenced this issue Jun 23, 2022
@lunny
Merge branch 'main' into go-gitea#20080-feed-paging
b42c960
jpraet added a commit to jpraet/gitea that referenced this issue Jun 23, 2022
@jpraet
Respect setting.UI.FeedPagingNum
edf9f9b 
Fixes go-gitea#20080
6543 pushed a commit that referenced this issue Jun 23, 2022
@jpraet
Respect setting.UI.FeedPagingNum (#20094)
b8cfd46 
Fixes #20080
6543 pushed a commit that referenced this issue Jun 23, 2022
@jpraet
Dashboard feed respect setting.UI.FeedPagingNum again (#20094) (#20099)
05464ac 
Fixes #20080
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
@jpraet
Respect setting.UI.FeedPagingNum (go-gitea#20094)
4235caa 
Fixes go-gitea#20080
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

Respect setting.UI.FeedPagingNum jpraet/gitea
Fix UI pagingnum lunny/gitea
2 participants
@lunny @jpraet