Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete creating problems with text entry, strange unicode (or user error) #20451

Closed
DarrenPIngram opened this issue Jul 22, 2022 · 3 comments
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@DarrenPIngram
Copy link

DarrenPIngram commented Jul 22, 2022

Description

With a new installation of Gitea (I am getting used to it, rather than use Github) I have had problems with some text, but not all text, creating issues that generate the exclamation point. See earlier report #19990 (comment)

It does seem to occur perhaps when auto-correct or auto-fill wants to leave its impression (how do you turn this off? I am using Gitea in default and see no options), e.g.

U+00a0 space and flashes up "adjust settings" but I've not found how to get that option working as you right click or move the mouse and it has gone.

READ FIRST
READ THEN
DRIVE FIRST
WET DOG
WET pig

All the above get the yellow box in edit mode and then alert when saved. Only wet pig (no capitals) did not create the problem.

Reproduced also at https://try.gitea.io/DarrenPIngram/test/src/branch/main/test

Screenshots

Screenshot 2022-07-22 at 13 00 27

Gitea Version

1.17.0+rc1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

MacOS 12.4

Browser Version

Google Chrome version 103.0.5060.114 (Official Build) (x86_64)

Edit: I managed after many attempts in a different place to turn off the highlighting at least, but I feel the default behaviour may not be right. But it does not seem to save the instructions, even with saving the page.

@DarrenPIngram DarrenPIngram added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 22, 2022
@zeripath
Copy link
Contributor

I really don't think the yellow boxing and warning of invisible characters is a bug here.

U+00A0   is not U+0020 .

Your confusion as to why the "space" is being detected as a "strange unicode error" clearly demonstrates that this is an ambiguous character in need of highlighting as being ambiguous.


As to why Monaco is suggesting nbsps here I don't know. I cannot replicate that.


If you're careful you can move the mouse cursor to get to the to the exclude menu but it appears that isn't actually connected. Now that is a bug - however at most a setting here would affect the editor only as it don't think it could be easily passed down to the main rendering system. I would guess the correct thing to do here is to disable that option.


Now, clearly we may want to think about if and when an nbsp can be non-ambiguous. I don't know when it would be appropriate to not highlight it. I guess it's fine for rendered files but I think it should still always be highlighted as an invisible character in a code view - it's just too ambiguous otherwise.

@DarrenPIngram
Copy link
Author

DarrenPIngram commented Jul 24, 2022 via email

@wxiaoguang
Copy link
Contributor

Similar issue here:

So I think this one could be closed. Let's improve the problem in the future.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

3 participants