Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post a review comment on pull request files view frontend error. #20809

Closed
lunny opened this issue Aug 16, 2022 · 0 comments · Fixed by #20814
Closed

Post a review comment on pull request files view frontend error. #20809

lunny opened this issue Aug 16, 2022 · 0 comments · Fixed by #20814
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Comments

@lunny
Copy link
Member

lunny commented Aug 16, 2022

regression from #20393

Uncaught (in promise) TypeError: el.getAttribute is not a function
    at initTooltip (tippy.js:26:22)
    at repo-diff.js:56:16
    at Generator.next (<anonymous>)
    at fulfilled (repo-common.js:108:1)
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 16, 2022
silverwind added a commit to silverwind/gitea that referenced this issue Aug 16, 2022
@silverwind
Fix tooltip init after review
545f012 
Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: go-gitea#20809
@silverwind silverwind mentioned this issue Aug 16, 2022
Merged
lafriks pushed a commit that referenced this issue Aug 16, 2022
@silverwind
Fix tooltip init after review (#20814)
1e0fcd1 
* Fix tooltip init after review

Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: #20809
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 28, 2022
@silverwind
Fix tooltip init after review (go-gitea#20814)
9f26437 
* Fix tooltip init after review

Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: go-gitea#20809
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tooltip init after review silverwind/gitea
1 participant
@lunny