Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript error after updating to 1.17.0 #20824

Closed
wolfbeast opened this issue Aug 17, 2022 · 6 comments
Closed

Javascript error after updating to 1.17.0 #20824

wolfbeast opened this issue Aug 17, 2022 · 6 comments
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@wolfbeast
Copy link

wolfbeast commented Aug 17, 2022

Description

I'm in the process of updating out Gitea instance to 1.17.0 from 1.12.6, and ran into it throwing a JS error after upgrading and migrating successfully.

09:54:40.024 error { target: SharedWorker, isTrusted: true, message: "ReferenceError: EventSource is not defined", filename: "https://repo.palemoon.org/assets/js/eventsource.sharedworker.js", lineno: 1, colno: 85, srcElement: SharedWorker, currentTarget: SharedWorker, eventPhase: 2, bubbles: false, cancelable: true } 1 index.js:37:15714
	Gg/< https://repo.palemoon.org/assets/js/index.js:37:15714

This is on the Pale Moon web browser (we use Gitea for Pale Moon development).
Of note, Pale Moon does not support the ambiguous global window.event MSIE quirk (deprecated on mainstream browsers also) which may be the issue here?

Screenshots

gitea1

Gitea Version

1.17.0

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Windows 10

Browser Version

Pale Moon 31.2.0.1

@wolfbeast wolfbeast added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 17, 2022
@lunny
Copy link
Member

lunny commented Aug 17, 2022

Should be fixed by #20663

@wolfbeast
Copy link
Author

wolfbeast commented Aug 17, 2022

Thanks!
I did some digging myself and found it seems to be because while we do support EventSource (and have since forever) and SharedWorkers, we currently don't support EventSource in workers. I opened an issue on our end to fix that, as well.

of note attempting to disable EventSource use through EVENT_SOURCE_UPDATE_TIME = -1 doesn't actually help here.

@silverwind
Copy link
Member

BTW, does PaleMoon support Websocket inside SharedWorker?

@wolfbeast
Copy link
Author

BTW, does PaleMoon support Websocket inside SharedWorker?

Yes, websockets are available in workers.

@eeyrjmr
Copy link
Contributor

eeyrjmr commented Aug 17, 2022

Is this related to or a duplicate of : #20572

@wolfbeast
Copy link
Author

@eeyrjmr Yes it seems to be a duplicate. I'll just wait for it to make it to the release train.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

4 participants