Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin can not delete users, the form is not submitted when clicking "yes" #20998

Closed
wxiaoguang opened this issue Aug 30, 2022 · 0 comments · Fixed by #21070
Closed

Admin can not delete users, the form is not submitted when clicking "yes" #20998

wxiaoguang opened this issue Aug 30, 2022 · 0 comments · Fixed by #21070
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.18.0

Comments

@wxiaoguang
Copy link
Contributor

It seems a regression bug of #18064

In #18064, the "Delete" button was changed from <div class="ui red button delete-button" to <div class="ui red button show-modal" , however, the .show-modal event handler seems not handling the form submit correctly.

IMO, the .delete-button event handler could handle the form submit, not sure why the CSS class is changed.
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Aug 30, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Aug 30, 2022
@wxiaoguang wxiaoguang mentioned this issue Aug 30, 2022
Merged
@jolheiser jolheiser mentioned this issue Sep 5, 2022
Merged
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 5, 2022
zeripath pushed a commit that referenced this issue Sep 12, 2022
@jolheiser
Use form for admin purge user (#21070)
2854031 
Fixes #20998

The basic modal actions were set up for basic confirmation-style modals,
however this modal also has a special form input, which instead requires
a form in the modal itself.
The basic modal actions are indirectly controlled by JS and are simple
`<div>` elements, whereas this requires a `<button>` to submit.

This appears to be similar to how we do it in (for example) the repo
deletion modal.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Use form for admin purge user jolheiser/gitea
2 participants
@lunny @wxiaoguang