Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planutuml section in customizing gitea needs update #21023

Closed
fkuep opened this issue Sep 1, 2022 · 1 comment · Fixed by #21142
Closed

planutuml section in customizing gitea needs update #21023

fkuep opened this issue Sep 1, 2022 · 1 comment · Fixed by #21142
Labels
type/bug type/docs This PR mainly updates/creates documentation

Comments

@fkuep
Copy link

fkuep commented Sep 1, 2022

Description

Plantuml stopped working for me updating from 1.5.4 to 1.7 .1
I found #16292 and solved the issue for myself.

Still however: current docs show the old way of doing it.
The earlier that is fixed , the less feedback You will receive.

Gitea Version

1.7.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

not applicable

Operating System

not applicable

How are you running Gitea?

gitea-1.17.1-linux-amd64 with a systemd unit file and giteaCUSTOM set.

Database

PostgreSQL

@fkuep fkuep added the type/bug label Sep 1, 2022
@fkuep
Copy link
Author

fkuep commented Sep 1, 2022

in gitea/custom/templates/custom/footer.tmpl it says one should insert:

<script>
  $(async () => {
    if (!$('.language-plantuml').length) return;
    await Promise.all([
      $.getScript('https://your-server.com/deflate.js'), 
      $.getScript('https://your-server.com/encode.js'),
      $.getScript('https://your-server.com/plantuml_codeblock_parse.js'),
    ]);
    // Replace call with address to your plantuml server
    parsePlantumlCodeBlocks("https://www.plantuml.com/plantuml");
  });
</script>

When it should now say:

<!-- left out start for brevity-->
      $.getScript('https://your-server.com/assets/deflate.js'), 
      $.getScript('https://your-server.com/assets/encode.js'),
      $.getScript('https://your-server.com/assets/plantuml_codeblock_parse.js'),
<!-- left out the rest for brevity-->      

@silverwind silverwind added the type/docs This PR mainly updates/creates documentation label Sep 1, 2022
lunny pushed a commit that referenced this issue Sep 11, 2022
The document was written before Gitea 1.15. Now Gitea uses `/assets`
sub-directory (#15219).

Close #21023
* #21023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/bug type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants