Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS feed GUIDs are not unique enough #21542

Closed
cthu1hoo opened this issue Oct 22, 2022 · 3 comments · Fixed by #21550
Closed

RSS feed GUIDs are not unique enough #21542

cthu1hoo opened this issue Oct 22, 2022 · 3 comments · Fixed by #21550
Labels
type/bug

Comments

@cthu1hoo
Copy link

cthu1hoo commented Oct 22, 2022 •
edited
Loading

Description

Running Gitea 1.17.2, RSS feed entries have a GUID which is an integer, i.e.

<item>
....
<guid>8669</guid>
<pubDate>Sat, 15 Oct 2022 13:46:05 +0300</pubDate>
</item>

Article GUID is supposed to globally identify it between any amount of other RSS feeds. An integer value is not good enough here and may easily clash with other entries. Something like a tag: URI or a simple permalink would work a lot better.

Even removing this field entirely would be better than current behavior. Please consider fixing this, thanks!

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Running stock docker container.

Database

PostgreSQL
@cthu1hoo cthu1hoo changed the title RSS feed GUID is not unique enough RSS feed GUIDs are not unique enough Oct 22, 2022
@yardenshoham
Copy link
Member

yardenshoham commented Oct 22, 2022 •
edited
Loading

What do you think about the format integer: link for guid? Say someone comments and the activity link is https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1#issuecomment-5 then it would be something like

<guid>
8: https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1#issuecomment-5
<guid/>

@cthu1hoo
Copy link
Author

Anything would work, as long as it is reasonably unique. I'm not aware of any other requirements for article GUIDs.

There's a link element already which supposedly goes somewhere unique for each article (I haven't checked, just assuming) so you could just use it once more inside <guid isPermaLink="true">....</guid>.

But really, anything unique would be good enough.

@yardenshoham
Copy link
Member

I'm on it

@yardenshoham yardenshoham mentioned this issue Oct 22, 2022
Merged
techknowlogick pushed a commit that referenced this issue Oct 28, 2022
@yardenshoham @lafriks
Make rss/atom identifier globally unique (#21550)
5f0cbb3 
This field should be globally unique.

[RSS
reference](https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt).

### Before
```xml
    <item>
      <title>abc opened issue &lt;a href=&#34;https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1&#34;&gt;abc/defg#1&lt;/a&gt;</title>
      <link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1</link>
      <description>1#Colors</description>
      <content:encoded><![CDATA[<p><code>#FF0000<span class="color-preview" style="background-color: #FF0000"></span></code></p>
]]></content:encoded>
      <author>abc</author>
      <guid>2</guid>
      <pubDate>Mon, 17 Oct 2022 16:06:08 +0000</pubDate>
    </item>
    <item>
      <title>abc created repository &lt;a href=&#34;https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg&#34;&gt;abc/defg&lt;/a&gt;</title>
      <link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg</link>
      <description></description>
      <author>abc</author>
      <guid>1</guid>
      <pubDate>Mon, 17 Oct 2022 16:05:43 +0000</pubDate>
    </item>
```
### After
```xml
    <item>
      <title>abc opened issue &lt;a href=&#34;https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1&#34;&gt;abc/defg#1&lt;/a&gt;</title>
      <link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1</link>
      <description>1#Colors</description>
      <content:encoded><![CDATA[<p><code>#FF0000<span class="color-preview" style="background-color: #FF0000"></span></code></p>
]]></content:encoded>
      <author>abc</author>
      <guid>2: https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1</guid>
      <pubDate>Mon, 17 Oct 2022 16:06:08 +0000</pubDate>
    </item>
    <item>
      <title>abc created repository &lt;a href=&#34;https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg&#34;&gt;abc/defg&lt;/a&gt;</title>
      <link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg</link>
      <description></description>
      <author>abc</author>
      <guid>1: https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg</guid>
      <pubDate>Mon, 17 Oct 2022 16:05:43 +0000</pubDate>
    </item>
```

* Fixes #21542

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make rss/atom identifier globally unique yardenshoham/gitea
2 participants
@yardenshoham @cthu1hoo