Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale of avatar for user in Issue history is larger than it should be #21924

Closed
wxiaoguang opened this issue Nov 24, 2022 · 1 comment · Fixed by #21990
Closed

Scale of avatar for user in Issue history is larger than it should be #21924

wxiaoguang opened this issue Nov 24, 2022 · 1 comment · Fixed by #21990
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.18.0

Comments

@wxiaoguang
Copy link
Contributor

main branch, https://try.gitea.io , any issue with edit history, eg: https://try.gitea.io/wxiaoguang/test/issues/1

The avatar is broken, it's shown as the original size.

image
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Nov 24, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Nov 24, 2022
@silverwind
Copy link
Member

Vertical centering also needs to be fixed.

@techknowlogick techknowlogick changed the title Issue history avatar is broken Scale of avatar for user in Issue history is larger than it should be Nov 25, 2022
silverwind added a commit to silverwind/gitea that referenced this issue Nov 30, 2022
@silverwind
Multiple improvements for comment edit diff
30dc426 
- Use explicit avatar size so when JS copies the HTML, the size gets
  copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering

Fixes: go-gitea#21924
@silverwind silverwind mentioned this issue Nov 30, 2022
Merged
lafriks pushed a commit that referenced this issue Dec 2, 2022
@silverwind @lunny @techknowlogick
Multiple improvements for comment edit diff (#21990)
d640632 
- Use explicit avatar size so when JS copies the HTML, the size gets
copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering
- Sort lists in `svg.js`

Fixes: #21924

<img width="933" alt="Screenshot 2022-11-30 at 17 52 17"
src="https://user-images.githubusercontent.com/115237/204859608-f322a8f8-7b91-45e4-87c0-82694e574115.png">

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
silverwind added a commit to silverwind/gitea that referenced this issue Dec 2, 2022
@silverwind @lunny @techknowlogick
Multiple improvements for comment edit diff (go-gitea#21990)
371fd2d 
- Use explicit avatar size so when JS copies the HTML, the size gets
copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering
- Sort lists in `svg.js`

Fixes: go-gitea#21924

<img width="933" alt="Screenshot 2022-11-30 at 17 52 17"
src="https://user-images.githubusercontent.com/115237/204859608-f322a8f8-7b91-45e4-87c0-82694e574115.png">

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@silverwind silverwind mentioned this issue Dec 2, 2022
Merged
techknowlogick added a commit that referenced this issue Dec 2, 2022
@silverwind @lunny @techknowlogick
Multiple improvements for comment edit diff (#21990) (#22007)
da956b8 
Backport #21990

- Use explicit avatar size so when JS copies the HTML, the size gets
copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering
- Sort lists in `svg.js`

Fixes: #21924

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Multiple improvements for comment edit diff silverwind/gitea
2 participants
@silverwind @wxiaoguang