Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect path to issue template file on windows #21987

Closed
crackedmind opened this issue Nov 30, 2022 · 2 comments · Fixed by #21993
Closed

Incorrect path to issue template file on windows #21987

crackedmind opened this issue Nov 30, 2022 · 2 comments · Fixed by #21993
Labels
type/bug

Comments

@crackedmind
Copy link

crackedmind commented Nov 30, 2022 •
edited
Loading

Description

after choosing template from the list issue body is empty, because template query parameter is wrong

?template=.gitea%5cISSUE_TEMPLATE%5cbug.md instead of ?template=.gitea%2fISSUE_TEMPLATE%2fbug.md

Manual fixing %5c to %2f in url helps

Gitea Version

1.18-rc1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows

How are you running Gitea?

From official gitea-1.18.0-rc1-windows-4.0-amd64.exe

Database

SQLite
@KazzmanK
Copy link
Contributor

Looks similar to 21632

@zeripath
Copy link
Contributor

Likely regression of #21639.

Paths in Git are always '/' separated.

zeripath added a commit to zeripath/gitea that referenced this issue Nov 30, 2022
@zeripath
Use path not filepath in template filenames
a1083b2 
Paths in git are always separated by `/` not `\\` - therefore we should `path` and not `filepath`

Fix go-gitea#21987

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Nov 30, 2022
Merged
lunny added a commit that referenced this issue Dec 1, 2022
@zeripath @lunny @lafriks
Use path not filepath in template filenames (#21993)
64973cf 
Paths in git are always separated by `/` not `\` - therefore we should
`path` and not `filepath`

Fix #21987

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
zeripath added a commit to zeripath/gitea that referenced this issue Dec 3, 2022
@zeripath @lunny @lafriks
Use path not filepath in template filenames (go-gitea#21993)
bdfbfc4 
Backport go-gitea#21993

Paths in git are always separated by `/` not `\` - therefore we should
`path` and not `filepath`

Fix go-gitea#21987

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@zeripath zeripath mentioned this issue Dec 3, 2022
Merged
lunny added a commit that referenced this issue Dec 4, 2022
@zeripath @lunny @lafriks
Use path not filepath in template filenames (#21993) (#22022)
c7770fa 
Backport #21993

Paths in git are always separated by `/` not `\` - therefore we should
`path` and not `filepath`

Fix #21987

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use path not filepath in template filenames zeripath/gitea
3 participants
@crackedmind @zeripath @KazzmanK