Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User secrets #22183

Closed
delvh opened this issue Dec 20, 2022 · 5 comments · Fixed by #22191
Closed

User secrets #22183

delvh opened this issue Dec 20, 2022 · 5 comments · Fixed by #22191
Assignees
@KN4CK3R
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@delvh
Copy link
Member

delvh commented Dec 20, 2022

Currently, we have both org- and repo secrets.
Some users already reported that they would like to have secrets that are shared across their own repos as well.
The code base should already allow that already, the only thing that needs to be added is a settings page to configure the user secrets.

Originally posted by @KN4CK3R in #22142 (comment), but extracted into its own issue to get the PR merged
@delvh delvh added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 20, 2022
@KN4CK3R KN4CK3R self-assigned this Dec 20, 2022
@KN4CK3R KN4CK3R mentioned this issue Dec 20, 2022
Merged
@silverwind
Copy link
Member

Currently, we have both org- and repo secrets

Is that a toggle-able feature? I don't see any secrets tab on repo/org on 1.19.

@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 21, 2022

The secrets are in the settings of the repo/org.

@silverwind
Copy link
Member

silverwind commented Dec 21, 2022 •
edited
Loading

Ah, I do see the tab on try.gitea.io, but not on my local instances, must be something in the config or db that's preventing the tabs from showing.

@delvh
Copy link
Member Author

delvh commented Dec 21, 2022

Are you sure you have that commit already on your instance?
Because it was only merged 36 hours ago, and I don't remember any config option in the PR…

@silverwind
Copy link
Member

Ah, I was out of date. Did miss that PR apparently.

@delvh delvh mentioned this issue Jan 3, 2023
Merged
lunny added a commit that referenced this issue Feb 1, 2023
@KN4CK3R @lunny
Add user secrets (#22191)
5882e17 
Fixes #22183
Replaces #22187

This PR adds secrets for users. I refactored the files for organizations
and repos to use the same logic and templates. I splitted the secrets
from deploy keys again and reverted the fix from #22187.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KN4CK3R KN4CK3R

Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add user secrets KN4CK3R/gitea
3 participants
@silverwind @KN4CK3R @delvh