Syntax Highlighting in arc-green Colors all Identifiers in Orange

[julmb]

Description

From 1.17.1 to 1.17.2, syntax highlighting when viewing files in the arc-green theme changed in such a way that many parts of the code are assigned the same orange color. This is inconsistent with both the gitea theme and the way arc-green behaves when editing files.

For instance, in screenshot [1], regular identifiers use the regular text color, and special identifiers like function names and built-in types get a special color. In screenshot [2], all of these identifiers get the same orange color. In all of the code files I have looked at, the majority of the text was orange rather than the regular gray text color. This does not happen when editing files [3]. The light theme also uses regular text color for regular identifiers and special colors for special identifiers [4].

Syntax highlighting when viewing files in the arc-green theme seems to work the same way in 1.18.0 as it does in 1.17.2

Screenshots

[1] 1.17.1 - arc-green - view file

[2] 1.17.2 - arc-green - view file

[3] 1.17.2 - arc-green - edit file

[4] 1.17.2 - gitea - view file

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Chromium Version 108.0.5359.124 (Official Build) Arch Linux (64-bit)

[silverwind]

Likely a C++ specific issue. Can you push an example to https://try.gitea.io/?

[wxiaoguang]

https://try.gitea.io/wxiaoguang/test/src/branch/master/test.cpp

kt and n use the same color in arc-green.

[julmb]

Likely a C++ specific issue. Can you push an example to https://try.gitea.io/?

From my experiments, it happens in at least C++, Java, C#, Haskell, and Python. In fact, so far, I have not seen a language where it does not happen.

I have uploaded some examples to try.gitea.io:
https://try.gitea.io/jules/highlighting-test/src/branch/main/main.cpp
https://try.gitea.io/jules/highlighting-test/src/branch/main/Main.hs
https://try.gitea.io/jules/highlighting-test/src/branch/main/main.java
https://try.gitea.io/jules/highlighting-test/src/branch/main/main.py

All of these have the distinct "everything is orange" look, where all identifiers are assigned the same color.

[wxiaoguang]

Fix broken highlight styles #23148

[stuzer05]

@lunny @delvh Should this issue be in 1.20.0 milestone, not in 1.19.0? The only not closed pr referencing this issue has 1.20.0 milestone and here's no backport flair anymore

[lunny]

@lunny @delvh Should this issue be in 1.20.0 milestone, not in 1.19.0? The only not closed pr referencing this issue has 1.20.0 milestone and here's no backport flair anymore

@wxiaoguang said he will take this issue after 1.19.0 or 1.19.1. So I think this should not prevent to release 1.19.0

[wxiaoguang]

I have proposed #23174 , @silverwind might want to do some changes (ping about progress).

ps: it doesn't need to block 1.19.0 release. If 1.19.0 is ready, it could be released and backport the fix later.

[silverwind]

Yeah I will have look shortly. Agree it's not blocking 1.19 because IIRC the issue is present on 1.18 as well.