Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to user/org avatar for /[username].png #22355

Closed
crystalcommunication opened this issue Jan 6, 2023 · 3 comments · Fixed by #22356
Closed

Redirect to user/org avatar for /[username].png #22355

crystalcommunication opened this issue Jan 6, 2023 · 3 comments · Fixed by #22356
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@crystalcommunication
Copy link
Contributor

Feature Description

GitHub has this feature that allows you to get redirected to any user's avatar by simply adding .png to their profile URL (e.g. https://github.com/go-gitea.png)

It would be fantastic if Gitea could do the same thing. Interestingly, Gitea already checks for a URL like this as of #18798, but instead of returning anything useful, it just returns the text Not Found (not even the fancy 404 page).

If this seems like a good idea, I can get a pull request going right away.

Screenshots

No response
@crystalcommunication crystalcommunication added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jan 6, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 6, 2023

Don't know why this was never implemented but it's already a long time in there (7 years):
a49af93

@crystalcommunication
Copy link
Contributor Author

Oh, you're right. The PR I mentioned only introduced the current code that handles it. Is there any particular reason for the current behavior? Right now it kinda just seems like it's partially implemented (though all the necessary functions exist)

@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 6, 2023

Don't think so, go for it.

@crystalcommunication crystalcommunication mentioned this issue Jan 6, 2023
Merged
KN4CK3R pushed a commit that referenced this issue Jan 6, 2023
@crystalcommunication @lunny
make /{username}.png redirect to user/org avatar (#22356)
d42b52f 
fix #22355

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make /{username}.png redirect to user/org avatar crystalcommunication/gitea
2 participants
@KN4CK3R @crystalcommunication