Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attachment of review not sent if no main review comment given #22647

Closed
JohaJung opened this issue Jan 28, 2023 · 0 comments · Fixed by #23035
Closed

attachment of review not sent if no main review comment given #22647

JohaJung opened this issue Jan 28, 2023 · 0 comments · Fixed by #23035
Labels
Milestone

Comments

@JohaJung
Copy link

Description

Steps to reproduce:
Do a review of a PR, with some inline comments.
Then click the review button at the top, and in the popup field upload an attachment, but do not enter text into that "main comment" filed.

Expected behaviour:
The review is submitted, with all inline comments and the attachment.

Observed behaviour:
The review gets submitted with all inline comments, but the attachment is not visible, there is no main comment block where one'd expect it.

Gitea Version

1.18.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian stable (bullseye)

How are you running Gitea?

Installed from download.

Database

MySQL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants