Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language will be changed to user's language after update profile #22703

Closed
yp05327 opened this issue Feb 1, 2023 · 0 comments · Fixed by #22748
Closed

language will be changed to user's language after update profile #22703

yp05327 opened this issue Feb 1, 2023 · 0 comments · Fixed by #22748
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.19.0

Comments

@yp05327
Copy link
Contributor

yp05327 commented Feb 1, 2023 •
edited
Loading

Description

e.g.

  1. current login user's language setting is English.
  2. change the page language to Chinese by using the language selector at the page foot
  3. open user settings page and click update profile, the page language will be changed to English.
  4. but if you cilck update avatar, it will not be changed.

If the page language be changed, this change will not be saved to user's setting.
So maybe we need to add a save proccess when we change the language by using the selector at page foot?
Or just fix the process of update profile

Gitea Version

1.19.0+dev-392-gfd29071e5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

try.gitea.io

Database

None
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 1, 2023
@yp05327 yp05327 mentioned this issue Feb 4, 2023
Merged
@lunny lunny added this to the 1.19.0 milestone Feb 5, 2023
lunny added a commit that referenced this issue Feb 5, 2023
@yp05327 @lunny
remove update language in ProfilePost (#22748)
c07199f 
Fixes #22703

Change language has been moved to `UpdateUserLang`

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

remove update language in ProfilePost yp05327/gitea
2 participants
@lunny @yp05327