Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated settings in v1.19 #22736

Closed
2 tasks
yardenshoham opened this issue Feb 3, 2023 · 2 comments · Fixed by #22992
Closed
2 tasks

Remove deprecated settings in v1.19 #22736

yardenshoham opened this issue Feb 3, 2023 · 2 comments · Fixed by #22992
Labels
type/deprecation Previously provided functionality is removed
Milestone
1.19.0

Comments

@yardenshoham
Copy link
Member

yardenshoham commented Feb 3, 2023 •
edited
Loading

We should remove the deprecated settings as planned:
@yardenshoham yardenshoham added the type/deprecation Previously provided functionality is removed label Feb 3, 2023
@lunny
Copy link
Member

lunny commented Feb 4, 2023

I think we need to still have a warning log like the configuration has bee removed, please take a look at xxxx as well.

@yardenshoham yardenshoham added this to the 1.19.0 milestone Feb 4, 2023
@lunny
Copy link
Member

lunny commented Feb 16, 2023

Maybe we should review and merge #22405 first.

@lunny lunny mentioned this issue Feb 19, 2023
Merged
jolheiser pushed a commit that referenced this issue Feb 20, 2023
@lunny
handle deprecated settings (#22992)
d845be6 
Fix #22736
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/deprecation Previously provided functionality is removed
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

handle deprecated settings lunny/gitea
2 participants
@lunny @yardenshoham