-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated github issues incorrectly labeling all users as owner #22797
Comments
I will try to fix this bug |
techknowlogick
pushed a commit
that referenced
this issue
Feb 15, 2023
Fix #22797. ## Reason If a comment was migrated from other platforms, this comment may have an original author and its poster is always not the original author. When the `roleDescriptor` func get the poster's role descriptor for a comment, it does not check if the comment has an original author. So the migrated comments' original authors might be marked as incorrect roles. --------- Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
yardenshoham
pushed a commit
to yardenshoham/gitea
that referenced
this issue
Feb 15, 2023
…22914) Fix go-gitea#22797. ## Reason If a comment was migrated from other platforms, this comment may have an original author and its poster is always not the original author. When the `roleDescriptor` func get the poster's role descriptor for a comment, it does not check if the comment has an original author. So the migrated comments' original authors might be marked as incorrect roles. --------- Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
wolfogre
pushed a commit
that referenced
this issue
Feb 16, 2023
…22923) Backport #22914 Fix #22797. ## Reason If a comment was migrated from other platforms, this comment may have an original author and its poster is always not the original author. When the `roleDescriptor` func get the poster's role descriptor for a comment, it does not check if the comment has an original author. So the migrated comments' original authors might be marked as incorrect roles. Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
All users in all issues are incorrectly labeled as "owner" for a project migrated from github. For example, see:
migrated: tuxracer/react-canvas#169
source: Flipboard/react-canvas#169
Gitea Version
1.19.0+dev-403-gb6b8feb3d
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Gitea:
Github:
Git Version
No response
Operating System
No response
How are you running Gitea?
gitea.com
Database
None
The text was updated successfully, but these errors were encountered: