Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest main breaks PRs with comments #22961

Closed
gempir opened this issue Feb 17, 2023 · 3 comments · Fixed by #22962
Closed

Latest main breaks PRs with comments #22961

gempir opened this issue Feb 17, 2023 · 3 comments · Fixed by #22962
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone

Comments

@gempir
Copy link
Contributor

gempir commented Feb 17, 2023

Description

Adding a comment to a PR will cause the PR page to only answer with a 500.
I tried it on the 2 commits below and also the gitea demo instance.

Not sure at what point this bug came.

https://try.gitea.io/gempir/gempbot/pulls/1/files

Server error message:

2023/02/17 21:01:44 ...s/context/context.go:231:HTML() [E] [63efdd28-32] Render failed: template: shared/user/avatarlink:1:81: executing "shared/user/avatarlink" at <$.Context>: wrong type for value; expected context.Context; got interface {}
2023/02/17 21:01:44 [63efdd28-32] router: completed GET /gempir/gempbot/pulls/2/files for [::1]:33960, 500 Internal Server Error in 101.7ms @ repo/pull.go:672(repo.ViewPullFiles)

Test commits which were all broken (so has to be before):
Powered by Gitea Version: 1.19.0+dev-504-ge7ef94e00 Page: 187ms Template: 1ms
e7ef94e
bd820aa

Gitea Version

e7ef94e

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

locally on linux with the make command in the readme. But also happens on the try.gitea.io page.

Database

SQLite

@yardenshoham
Copy link
Member

How to reproduce?

@gempir
Copy link
Contributor Author

gempir commented Feb 17, 2023

Just add a comment on a code line

@yardenshoham yardenshoham added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 17, 2023
@yardenshoham yardenshoham added this to the 1.19.0 milestone Feb 17, 2023
@yardenshoham
Copy link
Member

Feels like a regression from #22294, reminds me of #22924

lunny added a commit that referenced this issue Feb 20, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants