Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closing issues via commit on non-default branch #2314

Closed
janstuemmel opened this issue Aug 16, 2017 · 4 comments · Fixed by #5622
Closed

closing issues via commit on non-default branch #2314

janstuemmel opened this issue Aug 16, 2017 · 4 comments · Fixed by #5622
Labels
type/bug
Milestone
1.7.0

Comments

@janstuemmel
Copy link

it's possible to close issues via commit message by pushing to a non-default branch, expected behavior should be that an issue only closes on commits on default branch (master). this is important for code reviewing workflows, where the code-reviewer megres/rebases a feature branch to master.

related: gogs/gogs#4699
@lafriks lafriks added this to the 1.x.x milestone Aug 16, 2017
@lunny
Copy link
Member

lunny commented Aug 17, 2017

@lafriks I think this is a feature not a bug.

@lafriks lafriks added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/bug labels Aug 17, 2017
@lafriks
Copy link
Member

lafriks commented Aug 17, 2017

@lunny I would call it undesired behaviour :) so it is somewhere in between :)

@bkcsoft bkcsoft added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Aug 24, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Aug 24, 2017

:trollface:

@janstuemmel
Copy link
Author

would consider this as bug, closing issue via commit in a feature branch should not be possible

@lunny lunny added type/bug and removed type/enhancement An improvement of existing functionality labels Nov 13, 2017
@HarshitOnGitHub HarshitOnGitHub mentioned this issue Jan 2, 2019
Merged
HarshitOnGitHub added a commit to HarshitOnGitHub/gitea that referenced this issue Jan 3, 2019
@HarshitOnGitHub
issue: Don't close issues via commits on non-default branch.
1d65f8c 
Adds a small check to close the issues only if the referencing commits
are on the default branch.

Fixes: go-gitea#2314.
@lafriks lafriks modified the milestones: 1.x.x, 1.7.0 Jan 4, 2019
lafriks pushed a commit that referenced this issue Jan 4, 2019
@HarshitOnGitHub @lafriks
Don't close issues via commits on non-default branch. (#5622)
9f476b8 
Adds a small check to close the issues only if the referencing commits
are on the default branch.

Fixes: #2314.
HarshitOnGitHub added a commit to HarshitOnGitHub/gitea that referenced this issue Jan 5, 2019
@HarshitOnGitHub
Don't close issues via commits on non-default branch. (go-gitea#5622)
c4e6479 
Adds a small check to close the issues only if the referencing commits
are on the default branch.

Fixes: go-gitea#2314.
@HarshitOnGitHub HarshitOnGitHub mentioned this issue Jan 5, 2019
Merged
lafriks pushed a commit that referenced this issue Jan 5, 2019
@HarshitOnGitHub @lafriks
Don't close issues via commits on non-default branch. (#5622) (#5643)
c9b57a5 
Adds a small check to close the issues only if the referencing commits
are on the default branch.

Fixes: #2314.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Don't close issues via commits on non-default branch. HarshitOnGitHub/gitea
4 participants
@lunny @lafriks @bkcsoft @janstuemmel