Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releases/tag page looks broken when no release has been created #23221

Closed
wiktor-k opened this issue Mar 1, 2023 · 3 comments
Closed

releases/tag page looks broken when no release has been created #23221

wiktor-k opened this issue Mar 1, 2023 · 3 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug type/enhancement An improvement of existing functionality
Milestone
1.20.0

Comments

@wiktor-k
Copy link
Contributor

wiktor-k commented Mar 1, 2023 •
edited
Loading

Description

GitHub properly displays release/tag page for tags even if the release has not been created:

2023-03-01-14-55-53

Live URL: https://github.com/wiktor-k/pysequoia/releases/tag/v0.1.14

Compare that with the same view of the same object in Gitea:

2023-03-01-14-56-09

Live URL: https://try.gitea.io/wiktor/pysequoia/releases/tag/v0.1.14

The title and description are missing and there's a broken markup (%!s(<nil>)) which should default to repository's default branch.

I'd be happy to contribute a fix if this is considered a valid issue.

Thanks for your time!

Gitea Version

1.20.0+dev-48-g04347eb81

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Screenshots attached in the bug description.

Git Version

No response

Operating System

No response

How are you running Gitea?

I'm using try.gitea.io

Database

None
@silverwind
Copy link
Member

The title and description are missing and there's a broken markup (%!s()) which should default to repository's default branch.

If by "title and description" you mean the tag message: Yes this would be a very welcome addition. I had requested in the past as well.

The <nil> is definitely a bug.

@silverwind silverwind added type/enhancement An improvement of existing functionality issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Mar 1, 2023
@wiktor-k wiktor-k mentioned this issue Mar 2, 2023
Merged
wiktor-k added a commit to wiktor-k/gitea that referenced this issue Mar 27, 2023
@wiktor-k
Unify tag display view with that of release
e7c96f7 
This patch makes Tag view look more similar to the one of
Release by making more template fragments reuse the same
markup.

Fixes: go-gitea#23221
lunny pushed a commit that referenced this issue Mar 27, 2023
@wiktor-k
Fix tags view (#23243)
b78c955 
This PR fixes several issues reported in
#23221.

It does three things:
1. Fixes the `DefaultBranch` variable that has not been set.
2. Sets `Title` and `Message` for newly created tags from the Tag
message. This makes it easier to create releases from tags that have
messages and for those that don't it doesn't have any effect.
3. Makes UI changes so that tags look more like proper releases.

Before:

![2023-03-02-12-31-19](https://user-images.githubusercontent.com/1718963/222416890-941a74d4-9cd0-4c45-a59e-199d2580cd8c.png)

After:

![2023-03-02-12-31-31](https://user-images.githubusercontent.com/1718963/222416919-abce2009-8955-4cd0-9bed-1374582e04f7.png)

I purposefully didn't reformat the template so that the diff is cleaner
but can do so if that's welcome.

Thanks for your time!

---------

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
@wiktor-k
Copy link
Contributor Author

🤔 hmm even though the commit was merged into main it didn't close this issue for some reason. I'll close it manually (as from my PoV it has been completed).

Thank you all for help! I really appreciate it! 🙏

@lunny lunny added this to the 1.20.0 milestone Mar 27, 2023
@silverwind
Copy link
Member

silverwind commented Mar 27, 2023 •
edited
Loading

🤔 hmm even though the commit was merged into main it didn't close this issue for some reason. I'll close it manually (as from my PoV it has been completed).

Thank you all for help! I really appreciate it! 🙏

GitHub's parser is not so smart and did not recognize your "This PR fixes several issues reported in #23221.".

If you put a simple "Fixes: #23221" next time, it will automatically pick it up and close the issue on merge.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

No branches or pull requests
3 participants
@lunny @silverwind @wiktor-k