Organization-wide projects bugs

[delvh]

Description

At the moment, organization-wide projects are riddled with bugs, based on preliminary user feedback from 1.19.0-rc1:
They are

• no one (not even the site admin) can edit/delete org projects, see screenshots 1 and 3
• repo projects allow to set the card preview type during creation. Organization projects don't, see screenshots 5 and 6
• Org projects ignore the column color, see screenshots 1 and 2, the right column should have the color #ff0000.

These issues can be fixed by sharing the code of repo projects with the organization projects.

Furthermore, the following issues are present:

• The organization Projects tab misses quite a few tabs as well as the organization settings, see screenshots 1, 3, and 5.
• When creating an org project, and adding a second column
  • and setting the second one as default, the initially created column disappears permanently, until the second column is deleted again. Happens both for repo- and org-projects. (Add unset default to project column #23401)
  • only the second column can be edited, the first one can't, see screenshot 1 and 2. Happens both for repo- and org-projects (Allow editing default project column #29873)
• If a repo disables projects, its issues cannot be assigned to org-wide projects either. While the current logic for that is clear (if isPackagesEnabled <list available projects> end), this would probably still be useful to implement.
• Both organization and repo projects cannot edit the column color anymore
• If you click on the PR that closed an issue inside an org-wide project, you get redirected to $URL/pull/$ID instead of $URL/$USER/$REPO/pull/$ID

Screenshots

Screenshot 1: Org project appearance

Screenshot 2: Repo project appearance

Screenshot 3: org repo projects list

Screenshot 4: Repo projects list

Screenshot 5: New org project

Screenshot 6: New repo project

Gitea Version

1.20.0+dev-90-gea7f0d6fc

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Linux

Browser Version

Firefox 110.0

[yp05327]

Thanks for your summarization.

I tried to fix some of them about one month ago
The first PR is

• Add missing tabs to org projects page #22705, but it seems not easy to fix it, as I found more problems in CI result:
• Add default owner team to privated_org and limited_org in unit test #23109 (Merged)
• "/api/packages/{username}/nuget" will always return http.StatusOK no matter whether doer has permission #23349
  ↑
  I designed a new solution to avoid this CI failure

The second one is #22865, but it is too big, I'm spliting this PR into several small ones. then it will be easier to review:

• Fix incorrect project links and use symlink icon for org-wide projects #23325
• Redirect to project again after editing it #23326
• Fix incorrect redirect link of delete org project #23327
• Do not store user projects as organization projects #23353
• Fix incorrect NotFound conditions in org/projects.go #23384
• Rename canWriteUnit to canWriteProjects #23386
• Show edit/close/delete button on organization wide repositories #23388
• Fix invalid issues in project boards #22865 (Show valid issues in project boards)

[yp05327]

@delvh

Org projects ignore the column color, see screenshots 1 and 2, the right column should have the color #ff0000.

I notice that we can not edit the column color in both repo and org/user projects in current main branch.
In 1.18.5, I can edit the column color in both repo projects.
It seems that the link is incorrect. I will fix this later.
Can you confirm this problem, and add to the task list?
Thanks.

↑
Fix: #23400

Maybe we need a test to avoid this again.

[yp05327]

repo projects allow to set the card preview type during creation. Organization projects don't, see screenshots 5 and 6

The select box will display nothing even if one is selected.

[6543]

org projects can only be assigned in issues where it's repo as projects enabled too

[delvh]

If a repo disables projects, its issues cannot be assigned to org-wide projects either. While the current logic for that is clear (if isPackagesEnabled end), this would probably still be useful to implement.

?

[HesterG]

Find another issue, Buttons used on "set defualt" and "delete column" are not proper, so cancel will disappear on hover. And this occurs on both repo and org level projects:

default.mov

IMO It is a good idea to use delete_modal_actions.tmpl here both to fix this issue and keep ui consistency as suggested by TODO here
I will open a PR to solve this.

[yp05327]

Maybe this problem is caused by css?
The button will not disappear in dark mode.

If I open devtools in chrome, the button works well in dark mode.
But if I close DevTools, the button will have no changes when mouse move across the button.

Open devtools:
mouse not on the button:

mouse on the button:

Close devtools (always same as mouse on the button):

Tested in gitea.com