custom label option appears twice

[eeyrjmr]

Description

when adding a custom yaml label file, an option appears twice. the glob appears to be searching for files as well as file types

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

#pwd
/var/lib/gitea/custom/options/label

#ls
test.yaml

#cat test.yaml
labels:
  - name: "foo/bar"  # name of the label that will appear in the dropdown
    exclusive: true # whether to use the exclusive namespace for scoped labels. scoped delimiter is /
    color: aabbcc # hex colour coding
    description: Some label # long description of label intent
  - name: "foo/baz"  # name of the label that will appear in the dropdown
    exclusive: true # whether to use the exclusive namespace for scoped labels. scoped delimiter is /
    color: aabbcc # hex colour coding
    description: Some other label # long description of label intent

Git Version

2.40.0

Operating System

linux (gentoo)

How are you running Gitea?

rc-service

Database

None

[eeyrjmr]

so the issue is here:

gitea/modules/label/parser.go

Lines 38 to 55 in 59eb660

	func GetTemplateFile(name string) ([]*Label, error) {
	data, err := options.Labels(name + ".yaml")
	if err == nil && len(data) > 0 {
	return parseYamlFormat(name+".yaml", data)
	}
	data, err = options.Labels(name + ".yml")
	if err == nil && len(data) > 0 {
	return parseYamlFormat(name+".yml", data)
	}
	data, err = options.Labels(name)
	if err != nil {
	return nil, ErrTemplateLoad{name, fmt.Errorf("GetRepoInitFile: %w", err)}
	}
	return parseLegacyFormat(name, data)
	}

line39 passes but also line 49 is executed. These might need to be an embedded if/else on the err