Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size of editor and preview should be the same #23816

Closed
vorlif opened this issue Mar 30, 2023 · 4 comments · Fixed by #24151
Closed

Font size of editor and preview should be the same #23816

vorlif opened this issue Mar 30, 2023 · 4 comments · Fixed by #24151
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@vorlif
Copy link

vorlif commented Mar 30, 2023

Description

Hi guys, first of all thanks for your work!

This is not really a bug, but it's been bothering me for a while. I think in the editor the font size for headings is overly large. I think nowhere in the entire Gitea UI are fonts used that large, and it would be nice if the font size in the editor and preview were identical.

Screenshots

image

The preview looks good, but uses completely different font sizes

image

Gitea Version

1.18, 1.19

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Arch Linux

Browser Version

Firefox 111 / Chrome 111
@vorlif vorlif added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 30, 2023
@lunny lunny added this to the 1.19.1 milestone Mar 30, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality and removed type/bug labels Mar 30, 2023
@silverwind
Copy link
Member

PR welcome to adjust those font sizes. Long-Term we well move away from the WYSIWYG editor to a plain textarea.

@silverwind silverwind removed this from the 1.19.1 milestone Mar 31, 2023
@silverwind
Copy link
Member

Don't see this as blocking for 1.19.1.

@silverwind
Copy link
Member

Default editor is now textarea with #23876, so this is obsolete.

This was referenced Apr 16, 2023
Merged
Merged
lunny pushed a commit that referenced this issue Apr 16, 2023
@wxiaoguang
Set EasyMDE heading font-size to the same size as the resulting markd…
0e05984 
…own (#24151)

Fix #23816

According to my personal experience, the EasyMDE is still useful when
writing a lot of contents, eg: the wiki page.

It's not difficult to improve its heading styles, so let's make it.

Before:

<img width="815" alt="image"
src="https://user-images.githubusercontent.com/2114189/232280943-9177f0bc-e380-426f-8588-20ff8d8e5293.png">

After:

<img width="538" alt="image"
src="https://user-images.githubusercontent.com/2114189/232280903-e8c476ee-f5b1-48fe-8a93-86fcd79680c3.png">
delvh pushed a commit that referenced this issue Apr 16, 2023
@wxiaoguang
Set EasyMDE heading font-size to the same size as the resulting markd…
94fbd44 
…own (#24151) (#24152)

Backport #24151

Fix #23816

<img width="519" alt="image"
src="https://user-images.githubusercontent.com/2114189/232283304-21f56e82-d80e-4199-9b14-74699d80cd20.png">
@wxiaoguang
Copy link
Contributor

I proposed 2 small PRs:

You can get the latest nightly build from https://dl.gitea.com/gitea/1.19/ or https://dl.gitea.com/gitea/main/ (for 1.20), or use latest docker image :1.19-dev or :dev (for 1.20)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set EasyMDE heading font-size to the same size as the resulting markdown wxiaoguang/gitea
4 participants
@lunny @silverwind @wxiaoguang @vorlif