Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tabs Have different Styling in Users/Organization Page #24108

Closed
yekanchi opened this issue Apr 13, 2023 · 0 comments · Fixed by #24162
Closed

Some tabs Have different Styling in Users/Organization Page #24108

yekanchi opened this issue Apr 13, 2023 · 0 comments · Fixed by #24162
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yekanchi
Copy link

yekanchi commented Apr 13, 2023

Description

It's Clear in These images that Projects/packages tab have different styling.
to see the difference go to one organization page and switch between Packages Tab and Repositories Tab

look at this links:
https://try.gitea.io/0101
https://try.gitea.io/0101/-/projects

and see the different styling of selected tabs

Screenshots

image
image

Gitea Version

1.19.1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows

Browser Version

109

@yekanchi yekanchi added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 13, 2023
silverwind pushed a commit that referenced this issue Apr 20, 2023
…24162)

Close #24108

Use secondary pointing menu for tabs on user/organization home page so
the tabs look the same.
Main changes:
1. modified a part of dom structure in
`templates/user/overview/header.tmpl` to make it the same as
`templates/org/header.tmpl` in order to produce the same ui.
2. Move some css to `web_src/css/shared/repoorgshared.css` to make them
shareable between `templates/user/overview/header.tmpl` and
`templates/org/header.tmpl`

After:


https://user-images.githubusercontent.com/17645053/232400617-2add5bec-d483-4ab1-b48d-eaee157f7b09.mov

For further improvements. Need some thoughts: 

For [this
TODO](https://github.com/HesterG/gitea/blob/729ad294cbec7a77623b2e3eab750ea7a20e8ee0/templates/user/overview/header.tmpl#L1),
it is viable to make it a shared template for [this
part](https://github.com/HesterG/gitea/blob/729ad294cbec7a77623b2e3eab750ea7a20e8ee0/templates/user/overview/header.tmpl#L2-L17)
and [this
part](https://github.com/HesterG/gitea/blob/729ad294cbec7a77623b2e3eab750ea7a20e8ee0/templates/org/header.tmpl#L1-L16)
because they are the same except for the variable. But for the menu
parts, they are quite different so might not be suitable to use a shared
template. So need some thoughts and advice about extracting the shared
template from these two headers.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant