404 error when Pull to repo with 'pull requests' disabled

[barzog]

Description

When we fork repo - forked repo is created with 'pull request' repo setting enabled. Old repo 'pull request' setting is left untouched. When we trying to create pull request from new repo to old repo we receive 404 'Not found' error if 'pull request' setting is disabled in old repo settings. More informative message is needed, or (more better) only repos with 'pull requests' enabled should shown in 'merge into' drop-down list.

Gitea Version

1.19.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

Flatcar

How are you running Gitea?

Kubernetes helm-chart on k3s running on flatcar linux.

Database

PostgreSQL

[lunny]

So should we allow repo to be forked if pull request siabled? 🤔

[barzog]

This may be even better (but I think that fork button should be shown anyway, but either in 'grayed' state - to show end-user that functionality is there but disabled or in 'normal' state with warning that 'you should enable PR on this repo beforehand.

[silverwind]

So should we allow repo to be forked if pull request siabled? 🤔

Absolutely not. Not all forks are for the purpose as a source of pull requests, they might become separate projects etc.