Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical overflow #24182

Closed
krzysztofjeziorny opened this issue Apr 18, 2023 · 6 comments
Closed

Vertical overflow #24182

krzysztofjeziorny opened this issue Apr 18, 2023 · 6 comments
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@krzysztofjeziorny
Copy link
Contributor

krzysztofjeziorny commented Apr 18, 2023

Description

Setting css of a .container (in the site footer) and .dashboard .dashboard-navbar to 100vw causes a vertical overflow in Firefox (v112).

On Chrome(ium) it is mitigated with overflow: overlay, but it isn't supported on Firefox yet.

On the demo site it is visible when creating a repo https://try.gitea.io/repo/create

Propsed change: removing the set width of 100vw on these classes eliminates the need of hacking the vertical overflow on the body (with overflow-x: hidden;).

Screenshots

Screenshot 2023-04-18 at 10 46 48

Gitea Version

1.19.1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

MacOS 12.6.5

Browser Version

112

@krzysztofjeziorny krzysztofjeziorny added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 18, 2023
@silverwind
Copy link
Member

I do not see any scrollbars in https://try.gitea.io/repo/create with Firefox 112 on MacOS. What's your version/os?

@krzysztofjeziorny
Copy link
Contributor Author

Operating System

MacOS 12.6.5

Browser Version

112

Also in Firefox Developer Edition, 113.0b4, without extensions.

@krzysztofjeziorny
Copy link
Contributor Author

Just had a thought: as it doesn't happen on my Debian/KDE Firefox installation, where the scrollbars are kind-of-nonexistent, I'll check that out:

MacOS general settings - Show scroll bars

And sure enough, when scrollbars are automatic, the layout is all right. When set to "Always", the overflow bug is now visible.

Should I create a PR with a layout fix?

@silverwind
Copy link
Member

Ah, yes I see it as well with "always" scrollbars. Please open a PR so we can test/discuss further.

@krzysztofjeziorny
Copy link
Contributor Author

@silverwind Pushed. Thanks for taking a look at it!

@wxiaoguang
Copy link
Contributor

Closed by #24184

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

3 participants