Add option to show outdated review comments #24913
Labels
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Comments
sebastian-sauer
added
type/feature
|
But some comments needs the context and the context may be changed. |
|
Upsource for example shows a warning on top of a comment like "Discussion is pointing to a modified code fragment" and a link to the original snippet. We could allow/add this (the old snippet is available). |
|
I've proposed a PR with screenshots of a possible solution - #24936 Happy to make changes based on your feedback. |
|
At least, we need an option to disable it for those who don't want to see the outdated comment which will only make confusing. |
The latest changes added an option to show outdated comments (will be stored in user settings if logged in) - so if you don't "enable" the feature by turning the option on, nothing should change and confuse. |
silverwind
added a commit
that referenced
this issue
Jun 21, 2023
If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes #24913 --------- Co-authored-by: silverwind <me@silverwind.io>
sebastian-sauer
added a commit
to sebastian-sauer/gitea
that referenced
this issue
Jun 21, 2023
Backport go-gitea#24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes go-gitea#24913 --------- Co-authored-by: silverwind <me@silverwind.io>
sebastian-sauer
added a commit
to sebastian-sauer/gitea
that referenced
this issue
Jun 21, 2023
Backport go-gitea#24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes go-gitea#24913 --------- Co-authored-by: silverwind <me@silverwind.io>
6543
pushed a commit
that referenced
this issue
Jun 22, 2023
Backport #24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes #24913 Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Description
Review comments get invalidated when for example the commit sha of the line they were created on changes.
This may happen due to the code author adding some lines at the beginning of the file.
Now all invalidated / outdated code comments are not shown in "Files changed" tab.
In order to check those comments i'll have to switch between "Files changed" tab and the conversation tab.
A new option to show outdated comments in "Files changed" tab would allow me to at least view all comments for a file in "Files changed" tab.
Even better would be to try to find the new line number for a comment - but the option to show outdated comments would already improve reviewing code with gitea (at least in my opinion) a lot.
Screenshots
No response
The text was updated successfully, but these errors were encountered: