Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel Branch Protection form doesn't cancel #25038

Closed
maospr opened this issue Jun 1, 2023 · 1 comment · Fixed by #25063
Closed

Cancel Branch Protection form doesn't cancel #25038

maospr opened this issue Jun 1, 2023 · 1 comment · Fixed by #25063
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.20.0

Comments

@maospr
Copy link

maospr commented Jun 1, 2023 •
edited
Loading

Description

Simplest way to reproduce is to add a new protection rule, enter a branch name pattern & scroll down to click 'Cancel'.
The result is a new rule with that name, I expected that no rule would be added.

The same goes for editing existing rules and clicking 'Cancel', it always tries to persist the changes instead of actually cancelling.

I've reproduced this on the Gitea demo site:
https://try.gitea.io/tester-bob/branch_prot_test/settings/branches

But the same issue is also present on version 1.19.2.

Gitea Version

1.20.0+dev-973-g5d23c885e

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Before:
image

Add new rule:
image
&Cancel:
image

After:
image

Git Version

2.40.1

Operating System

FreeBSD 13.2

How are you running Gitea?

Gitea is running within a FreeBSD jail and installed through the FreeBSD package manager.

Database

PostgreSQL
@maospr maospr added the type/bug label Jun 1, 2023
@wxiaoguang
Copy link
Contributor

The "Cancel" button was added by #20825 , but it is also a "submit" button, so it needs to be changed to a <a> with link.

@wxiaoguang wxiaoguang added this to the 1.20.0 milestone Jun 1, 2023
@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 1, 2023
@yardenshoham yardenshoham mentioned this issue Jun 3, 2023
Merged
lunny pushed a commit that referenced this issue Jun 3, 2023
@yardenshoham
Remove cancel button from branch protection form (#25063)
4486dd3 
It caused bugs. To cancel, just navigate away.

- Follows #21381 and #21872
- Resolves #25038 

## Before

![image](https://github.com/go-gitea/gitea/assets/20454870/068c8d96-fc50-4725-8af2-d953e9f39024)

## After

![image](https://github.com/go-gitea/gitea/assets/20454870/105d5c50-e490-456a-a253-269b174c09ab)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Remove cancel button from branch protection form yardenshoham/gitea
2 participants
@wxiaoguang @maospr