Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Add toggleable menu to settings navbars #25051

Closed
HesterG opened this issue Jun 2, 2023 · 1 comment · Fixed by #25098
Closed

[Proposal] Add toggleable menu to settings navbars #25051

HesterG opened this issue Jun 2, 2023 · 1 comment · Fixed by #25098
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@HesterG
Copy link
Contributor

HesterG commented Jun 2, 2023

Feature Description

Fomantic does not have it, we could add a js feature to implement this.

Screen Shot 2023-06-02 at 17 06 00 Screen Shot 2023-06-02 at 17 06 05

Screenshots

No response
@HesterG HesterG added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jun 2, 2023
@lunny lunny added topic/ui Change the appearance of the Gitea UI and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jun 2, 2023
@silverwind
Copy link
Member

silverwind commented Jun 2, 2023 •
edited
Loading

You don't need JS for this, just use <details> element:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

@HesterG HesterG mentioned this issue Jun 6, 2023
Merged
lunny pushed a commit that referenced this issue Jun 7, 2023
@HesterG @silverwind
Add details summary for vertical menus in settings to allow toggling (#…
5853609 
…25098)

Close #25051
[referenced
answer](https://stackoverflow.com/questions/10813581/can-i-replace-the-expand-icon-of-the-details-element/69722686#69722686)
for marker overwrite. One limitation is that fomantic does not have
hover and active effects for the vertical submenu
([reference](https://fomantic-ui.com/collections/menu.html#sub-menu)).
And we might need to overwrite some styles if hover and active effects
are needed.

Update:
Used `data:image/svg` instead of `marker` content. And adjusted styles
for hover effect.

Take admin settings as an example:

https://github.com/go-gitea/gitea/assets/17645053/63f69823-ef43-47d5-a518-544b5ea35ba6

---------

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add details summary for vertical menus in settings to allow toggling HesterG/gitea
3 participants
@lunny @silverwind @HesterG