Inconsistent value for [repository].ROOT causes errors on git push
#25107
Labels
Comments
|
You may need to run the resync hooks task in the admin dashboard. |
|
Hmm I've tried that, but unfortunately it didn't resolve the issue and I still receive the same error when pushing to repositories. |
|
Looked into this a little further - I think this is because the pre-receive hooks that are generated only apply the Here's a pre-receive hook from my repository: |
Closed
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this issue
Jun 21, 2023
# The problem
There were many "path tricks":
* By default, Gitea uses its program directory as its work path
* Gitea tries to use the "work path" to guess its "custom path" and
"custom conf (app.ini)"
* Users might want to use other directories as work path
* The non-default work path should be passed to Gitea by GITEA_WORK_DIR
or "--work-path"
* But some Gitea processes are started without these values
* The "serv" process started by OpenSSH server
* The CLI sub-commands started by site admin
* The paths are guessed by SetCustomPathAndConf again and again
* The default values of "work path / custom path / custom conf" can be
changed when compiling
# The solution
* Use `InitWorkPathAndCommonConfig` to handle these path tricks, and use
test code to cover its behaviors.
* When Gitea's web server runs, write the WORK_PATH to "app.ini", this
value must be the most correct one, because if this value is not right,
users would find that the web UI doesn't work and then they should be
able to fix it.
* Then all other sub-commands can use the WORK_PATH in app.ini to
initialize their paths.
* By the way, when Gitea starts for git protocol, it shouldn't output
any log, otherwise the git protocol gets broken and client blocks
forever.
The "work path" priority is: WORK_PATH in app.ini > cmd arg --work-path
> env var GITEA_WORK_DIR > builtin default
The "app.ini" searching order is: cmd arg --config > cmd arg "work path
/ custom path" > env var "work path / custom path" > builtin default
## ⚠️ BREAKING
If your instance's "work path / custom path / custom conf" doesn't meet
the requirements (eg: work path must be absolute), Gitea will report a
fatal error and exit. You need to set these values according to the
error log.
----
Close go-gitea#24818
Close go-gitea#24222
Close go-gitea#21606
Close go-gitea#21498
Close go-gitea#25107
Close go-gitea#24981
Maybe close go-gitea#24503
Replace go-gitea#23301
Replace go-gitea#22754
And maybe more
# Conflicts:
# cmd/web.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I am running gitea via the snap package, and have overridden the systemd unit file to set the
--work-pathand--custom-pathto a mounted volume on my server, since there is no other way that I know about to override the environment variables in thesnapcraft.yml.In
/etc/systemd/system/snap.gitea.web.service.d/override.conf:In the logs for gitea I see the values that I expect:
The
doctorcommand shows the Repository Root Path that I expect:However when I push commits to a repository, I receive the following error:
It seems like different bits of gitea disagree about the value of this configuration setting?
Happy to provide more logs/info if needed!
Gitea Version
1.19.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
2.34.1
Operating System
Ubuntu 22.04
How are you running Gitea?
The Gitea server is provisioned using cloud-init and gitea is started using the systemd unit file.
The unit file has been overridden to specify the data paths and user:
It has been given the
removable-mediapermission viasnap connect gitea:removable-mediabefore launching.The entire
app.inican be viewed as part of the cloud-init configuration here.Database
SQLite
The text was updated successfully, but these errors were encountered: