Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dissmiss a review on a pull request and input the reason but the reason missed on the conversation. #25127

Closed
lunny opened this issue Jun 8, 2023 · 4 comments · Fixed by #25461
Closed

Dissmiss a review on a pull request and input the reason but the reason missed on the conversation. #25127

lunny opened this issue Jun 8, 2023 · 4 comments · Fixed by #25461
Labels
type/bug
Milestone
1.20.0

Comments

@lunny
Copy link
Member

lunny commented Jun 8, 2023

图片
@lunny lunny added the type/bug label Jun 8, 2023
@lunny lunny added this to the 1.20.0 milestone Jun 8, 2023
@silverwind
Copy link
Member

silverwind commented Jun 14, 2023 •
edited
Loading

May be related to #24738, I'm not sure.

@silverwind
Copy link
Member

At least the rendering has not changed, so it might be a problem when the dismissal request is sent.

https://github.com/go-gitea/gitea/blame/main/templates/repo/issue/view_content/comments.tmpl#L76

@silverwind
Copy link
Member

The input form is pretty much pure copy-paste, so I think it's unlikely that that PR regressed it and this may be a older bug.

@wxiaoguang wxiaoguang mentioned this issue Jun 23, 2023
Merged
@wxiaoguang
Copy link
Contributor

It seems the bug exists from the beginning of the "dismiss" feature.

-> Make "dismiss" content shown correctly #25461

@GiteaBot GiteaBot mentioned this issue Jun 23, 2023
Merged
silverwind pushed a commit that referenced this issue Jun 23, 2023
@wxiaoguang @GiteaBot
Make "dismiss" content shown correctly (#25461)
17965c8 
Close #25127


![image](https://github.com/go-gitea/gitea/assets/2114189/7d6be811-8e4a-4982-a5e4-857d171758d4)

Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Jun 23, 2023
@wxiaoguang @GiteaBot
Make "dismiss" content shown correctly (go-gitea#25461)
db1c266 
Close go-gitea#25127


![image](https://github.com/go-gitea/gitea/assets/2114189/7d6be811-8e4a-4982-a5e4-857d171758d4)

Co-authored-by: Giteabot <teabot@gitea.io>
silverwind pushed a commit that referenced this issue Jun 23, 2023
@GiteaBot @wxiaoguang
Make "dismiss" content shown correctly (#25461) (#25465)
2e64449 
Backport #25461 by @wxiaoguang

Close #25127


![image](https://github.com/go-gitea/gitea/assets/2114189/7d6be811-8e4a-4982-a5e4-857d171758d4)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Make "dismiss" content shown correctly wxiaoguang/gitea
3 participants
@lunny @silverwind @wxiaoguang