Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook create events return incorrect ref_type #25185

Closed
Elara6331 opened this issue Jun 9, 2023 · 0 comments · Fixed by #25195
Closed

Webhook create events return incorrect ref_type #25185

Elara6331 opened this issue Jun 9, 2023 · 0 comments · Fixed by #25195
Labels
type/bug
Milestone
1.20.0

Comments

@Elara6331
Copy link

Elara6331 commented Jun 9, 2023 •
edited
Loading

Description

Since commit f9cfd6c (PR #24634), Gitea webhooks for create events have a ref_type of tags, rather than tag as it used to be and currently is on GitHub. This breaks webhook receivers such as Woodpecker CI. I don't think this change was intentional. If it was, I'll file an issue on the Woodpecker repo instead.

Gitea Version

1.20.0+rc0-9-gde1d14590

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

2.40.1

Operating System

Debian Bullseye

How are you running Gitea?

Official docker container, tag 1.20-nightly

Database

SQLite
@wxiaoguang wxiaoguang mentioned this issue Jun 10, 2023
Merged
@lunny lunny added this to the 1.20.0 milestone Jun 10, 2023
@lunny lunny mentioned this issue Jun 11, 2023
Merged
lunny added a commit that referenced this issue Jun 13, 2023
@lunny
Fix compatible for webhook ref type (#25195)
419804f 
Fix #25185 
Caused by #24634
@GiteaBot GiteaBot mentioned this issue Jun 13, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 13, 2023
@lunny @GiteaBot
Fix compatible for webhook ref type (go-gitea#25195)
5e6c078 
Fix go-gitea#25185 
Caused by go-gitea#24634
lunny added a commit that referenced this issue Jun 13, 2023
@GiteaBot @lunny
Fix compatible for webhook ref type (#25195) (#25223)
506c708 
Backport #25195 by @lunny

Fix #25185 
Caused by #24634

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix compatible for webhook ref type lunny/gitea
2 participants
@lunny @Elara6331