Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version for dev builds is not showing anymore #25350

Closed
stuzer05 opened this issue Jun 18, 2023 · 5 comments · Fixed by #25361
Closed

Version for dev builds is not showing anymore #25350

stuzer05 opened this issue Jun 18, 2023 · 5 comments · Fixed by #25361
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug

Comments

@stuzer05
Copy link

Description

Empty version in the footer, before there was a git commit hash

Gitea Version

trunk

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/

Database

None
@silverwind silverwind added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Jun 18, 2023
@techknowlogick techknowlogick mentioned this issue Jun 19, 2023
Merged
@makkes
Copy link

makkes commented Jun 19, 2023

This breaks the official go-sdk as in gitea.NewClient(host, gitea.SetToken("token")) returns an error:

Malformed version:

@noahziheng
Copy link

This breaks the official go-sdk as in gitea.NewClient(host, gitea.SetToken("token")) returns an error:

Malformed version:

I meet this problem too.

silverwind pushed a commit that referenced this issue Jun 19, 2023
@techknowlogick
Fetch all git data for embedding correct version in docker image (#25361
1a5b7c8 
)

Fix #25350
@GiteaBot GiteaBot mentioned this issue Jun 19, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 19, 2023
@techknowlogick @GiteaBot
Fetch all git data for embedding correct version in docker image (go-…
34e3b28 
…gitea#25361)

Fix go-gitea#25350
@techknowlogick
Copy link
Member

Reopening as my PR may not have actually fixed this

silverwind pushed a commit that referenced this issue Jun 20, 2023
@GiteaBot @techknowlogick
Fetch all git data for embedding correct version in docker image (#25361
10fcb55 
) (#25373)

Backport #25361 by @techknowlogick

Fix #25350

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@noahziheng
Copy link

This problem may be fixed by #25381 .

Version is showing in latest nightly image

@stuzer05
Copy link
Author

This problem may be fixed by #25381 .

Version is showing in latest nightly image

I can confirm, version is showing in the latest nightly build
image

@makkes makkes mentioned this issue Jun 20, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch all git data for embedding correct version in docker image techknowlogick/gitea
5 participants
@silverwind @techknowlogick @makkes @noahziheng @stuzer05